From d8c00498576b5c9587fff93f15d341550fbe009e Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Tue, 12 Sep 2023 09:27:05 -0400 Subject: [PATCH 1/3] chore(Checkbox): updated example CSS to use logical property --- .../react-core/src/components/Checkbox/examples/checkbox.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-core/src/components/Checkbox/examples/checkbox.css b/packages/react-core/src/components/Checkbox/examples/checkbox.css index fda8057cdae..337120879f2 100644 --- a/packages/react-core/src/components/Checkbox/examples/checkbox.css +++ b/packages/react-core/src/components/Checkbox/examples/checkbox.css @@ -1,3 +1,3 @@ .ws-react-c-checkbox .pf-v5-c-check.nested { - padding-left: var(--pf-v5-global--spacer--md); + padding-inline-start: var(--pf-v5-global--spacer--md); } From 62b44a36377924cb163e52d417df40a523fa6f17 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Thu, 14 Sep 2023 08:12:33 -0400 Subject: [PATCH 2/3] Moved nested checkboxes to body prop --- .../Checkbox/examples/CheckboxControlled.tsx | 34 ++++++++++--------- .../components/Checkbox/examples/checkbox.css | 3 -- 2 files changed, 18 insertions(+), 19 deletions(-) delete mode 100644 packages/react-core/src/components/Checkbox/examples/checkbox.css diff --git a/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx b/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx index 9c1e49f4e4c..3881eaf0700 100644 --- a/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx +++ b/packages/react-core/src/components/Checkbox/examples/CheckboxControlled.tsx @@ -49,22 +49,24 @@ export const CheckboxControlled: React.FunctionComponent = () => { onChange={handleChange} id="controlled-check-1" name="check1" - /> - - + + + + } /> Date: Thu, 14 Sep 2023 08:27:54 -0400 Subject: [PATCH 3/3] Removed import of deleted stylesheet --- .../src/components/Checkbox/examples/Checkbox.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/react-core/src/components/Checkbox/examples/Checkbox.md b/packages/react-core/src/components/Checkbox/examples/Checkbox.md index ded0812e34f..ec4499f7693 100644 --- a/packages/react-core/src/components/Checkbox/examples/Checkbox.md +++ b/packages/react-core/src/components/Checkbox/examples/Checkbox.md @@ -6,46 +6,52 @@ cssPrefix: pf-v5-c-check propComponents: ['Checkbox'] --- -import './checkbox.css'; - ## Examples ### Controlled ```ts file='./CheckboxControlled.tsx' + ``` ### Uncontrolled ```ts file='./CheckboxUncontrolled.tsx' + ``` ### Disabled ```ts file='./CheckboxDisabled.tsx' + ``` ### Checkbox with description ```ts file='./CheckboxWithDescription.tsx' + ``` ### Checkbox with body ```ts file='./CheckboxWithBody.tsx' + ``` ### Checkbox with description and body ```ts file='./CheckboxWithDescriptionBody.tsx' + ``` ### Standalone input ```ts file='./CheckboxStandaloneInput.tsx' + ``` ### Required input ```ts file='./CheckboxRequired.tsx' + ```