From 59bc86aba0a9f3f2c3f1d0360c4b5a153632085f Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Mon, 13 Nov 2023 10:45:17 -0500 Subject: [PATCH 1/2] fix(Chip): enable tooltip when chip updates --- packages/react-core/src/components/Chip/Chip.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/react-core/src/components/Chip/Chip.tsx b/packages/react-core/src/components/Chip/Chip.tsx index 52c6c62d518..1d3e2ec9089 100644 --- a/packages/react-core/src/components/Chip/Chip.tsx +++ b/packages/react-core/src/components/Chip/Chip.tsx @@ -81,6 +81,15 @@ class Chip extends React.Component { }); } + componentDidUpdate(_prevProps: ChipProps, prevState: ChipState) { + const nextIsTooltipVisible = this.span.current && this.span.current.offsetWidth < this.span.current.scrollWidth; + if (prevState.isTooltipVisible !== nextIsTooltipVisible) { + this.setState({ + isTooltipVisible: nextIsTooltipVisible + }); + } + } + setChipStyle = () => ({ [cssChipTextMaxWidth.name]: this.props.textMaxWidth }); From 87bb9b1098645e55e18c3e54ed2bd6d80d85f600 Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Tue, 14 Nov 2023 13:48:38 -0500 Subject: [PATCH 2/2] fix casting --- packages/react-core/src/components/Chip/Chip.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/react-core/src/components/Chip/Chip.tsx b/packages/react-core/src/components/Chip/Chip.tsx index 1d3e2ec9089..12ab24e665c 100644 --- a/packages/react-core/src/components/Chip/Chip.tsx +++ b/packages/react-core/src/components/Chip/Chip.tsx @@ -82,7 +82,9 @@ class Chip extends React.Component { } componentDidUpdate(_prevProps: ChipProps, prevState: ChipState) { - const nextIsTooltipVisible = this.span.current && this.span.current.offsetWidth < this.span.current.scrollWidth; + const nextIsTooltipVisible = Boolean( + this.span.current && this.span.current.offsetWidth < this.span.current.scrollWidth + ); if (prevState.isTooltipVisible !== nextIsTooltipVisible) { this.setState({ isTooltipVisible: nextIsTooltipVisible