From 7db1b2bde56062c0d5d61ddc6bc035685da9387b Mon Sep 17 00:00:00 2001 From: adri09070 Date: Fri, 8 Jul 2022 11:49:51 +0200 Subject: [PATCH 1/3] Synchronising changes with Pharo repo so that testIsExecutionFinished passes --- Sindarin/SindarinDebugger.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sindarin/SindarinDebugger.class.st b/Sindarin/SindarinDebugger.class.st index a0d3163..a1c89ac 100644 --- a/Sindarin/SindarinDebugger.class.st +++ b/Sindarin/SindarinDebugger.class.st @@ -269,7 +269,7 @@ SindarinDebugger >> isAboutToSignalException [ SindarinDebugger >> isExecutionFinished [ "Returns whether the debugged execution is finished" - ^ process isTerminating + ^ process isTerminated ] { #category : #stackAccessHelpers } From 33ff71019b4c512f858f1aa63e7ae56bf8895c7c Mon Sep 17 00:00:00 2001 From: adri09070 Date: Fri, 8 Jul 2022 12:03:37 +0200 Subject: [PATCH 2/3] Formatting code and deleting obsolete comment --- Sindarin-Tests/SindarinDebuggerTest.class.st | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Sindarin-Tests/SindarinDebuggerTest.class.st b/Sindarin-Tests/SindarinDebuggerTest.class.st index 2489f59..018db99 100644 --- a/Sindarin-Tests/SindarinDebuggerTest.class.st +++ b/Sindarin-Tests/SindarinDebuggerTest.class.st @@ -385,15 +385,12 @@ SindarinDebuggerTest >> testIsAboutToInstantiateClass [ { #category : #tests } SindarinDebuggerTest >> testIsExecutionFinished [ - "Test shows that the debugger is actually not correctly working and therefore it is disabled. - The fix requires the changes in #isExecutionFinished and on the Pharo side (PR#8567) - Once integrated there will be another PR here. - Projects are managed in different repos and therfore such complex integration" + | scdbg | self skipOnPharoCITestingEnvironment. scdbg := SindarinDebugger debug: [ self helperMethod16 ]. self deny: scdbg isExecutionFinished. - + [ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ]. self assert: scdbg currentProcess isTerminated From 72057cb8f7bad84fa1388d5851d9acf5ef8029e7 Mon Sep 17 00:00:00 2001 From: adri09070 Date: Fri, 8 Jul 2022 12:08:11 +0200 Subject: [PATCH 3/3] categorising method --- Sindarin/SindarinDebugger.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sindarin/SindarinDebugger.class.st b/Sindarin/SindarinDebugger.class.st index a1c89ac..6f0af6b 100644 --- a/Sindarin/SindarinDebugger.class.st +++ b/Sindarin/SindarinDebugger.class.st @@ -382,7 +382,7 @@ SindarinDebugger >> openInGraphicalDebugger [ 'Should be an extension of DebuggerSelector and handled by its sole instance' ] -{ #category : #'as yet unclassified' } +{ #category : #'accessing - context' } SindarinDebugger >> outerMostContextOf: aContext [ | currentContext oldContext |