From 70ce2973353dcb1966c1e65d3d99c7ce9455613b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hern=C3=A1n=20Morales=20Durand?= Date: Thu, 1 Feb 2024 11:25:57 +0100 Subject: [PATCH 1/2] Fix a failing test, thanks to @StevenCostiou --- src/Sindarin-Tests/SindarinDebuggerTest.class.st | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Sindarin-Tests/SindarinDebuggerTest.class.st b/src/Sindarin-Tests/SindarinDebuggerTest.class.st index 3992366..7402d0f 100644 --- a/src/Sindarin-Tests/SindarinDebuggerTest.class.st +++ b/src/Sindarin-Tests/SindarinDebuggerTest.class.st @@ -1787,11 +1787,13 @@ SindarinDebuggerTest >> testStepOver [ { #category : #tests } SindarinDebuggerTest >> testStepOverFinishedExecution [ + "This test tries to show is that using Sindarin on a block, it should raise an exception if you continue stepping over that code in your Sindarin script while the execution of that code is already finished (nothing more to step)" + |scdbg| scdbg := SindarinDebugger debug: [ self methodWithImplicitReturn ]. "Stepping until the implicit return of #methodWithImplicitReturn" - scdbg stepOver: 3. + scdbg stepOver: 2. self should: [scdbg stepOver] raise: DebuggedExecutionIsFinished ] From 1269b4fe07031b7eee040654f506702d75788b4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hern=C3=A1n=20Morales=20Durand?= Date: Thu, 1 Feb 2024 11:34:49 +0100 Subject: [PATCH 2/2] Fix another failing test: testIsExecutionFinished. Same way to previous fix, check DebuggedExecutionIsFinished is raised --- src/Sindarin-Tests/SindarinDebuggerTest.class.st | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Sindarin-Tests/SindarinDebuggerTest.class.st b/src/Sindarin-Tests/SindarinDebuggerTest.class.st index 7402d0f..5a18d38 100644 --- a/src/Sindarin-Tests/SindarinDebuggerTest.class.st +++ b/src/Sindarin-Tests/SindarinDebuggerTest.class.st @@ -506,8 +506,10 @@ SindarinDebuggerTest >> testIsExecutionFinished [ scdbg := SindarinDebugger debug: [ self methodWithTwoAssignments ]. self deny: scdbg isExecutionFinished. - [ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ]. - + self + should: [ [ scdbg isExecutionFinished ] whileFalse: [ scdbg stepOver ] ] + raise: DebuggedExecutionIsFinished. + self assert: scdbg currentProcess isTerminated ]