From ba9becf4ef382422aae6961cfe318b4a49a2d4bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vo=C5=99=C3=AD=C5=A1ek?= Date: Fri, 6 Dec 2024 15:40:20 +0100 Subject: [PATCH] Do not extend lock/unlock methods visibility --- src/mutex/MySQLMutex.php | 4 ++-- src/mutex/PgAdvisoryLockMutex.php | 4 ++-- tests/mutex/PgAdvisoryLockMutexTest.php | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mutex/MySQLMutex.php b/src/mutex/MySQLMutex.php index ec3aea5b..a2292318 100644 --- a/src/mutex/MySQLMutex.php +++ b/src/mutex/MySQLMutex.php @@ -30,7 +30,7 @@ public function __construct(\PDO $PDO, string $name, float $timeout = 0) } #[\Override] - public function lock(): void + protected function lock(): void { $statement = $this->pdo->prepare('SELECT GET_LOCK(?, ?)'); @@ -62,7 +62,7 @@ public function lock(): void } #[\Override] - public function unlock(): void + protected function unlock(): void { $statement = $this->pdo->prepare('DO RELEASE_LOCK(?)'); $statement->execute([ diff --git a/src/mutex/PgAdvisoryLockMutex.php b/src/mutex/PgAdvisoryLockMutex.php index 5233df95..2e210861 100644 --- a/src/mutex/PgAdvisoryLockMutex.php +++ b/src/mutex/PgAdvisoryLockMutex.php @@ -31,7 +31,7 @@ public function __construct(\PDO $PDO, string $name) } #[\Override] - public function lock(): void + protected function lock(): void { $statement = $this->pdo->prepare('SELECT pg_advisory_lock(?, ?)'); @@ -42,7 +42,7 @@ public function lock(): void } #[\Override] - public function unlock(): void + protected function unlock(): void { $statement = $this->pdo->prepare('SELECT pg_advisory_unlock(?, ?)'); $statement->execute([ diff --git a/tests/mutex/PgAdvisoryLockMutexTest.php b/tests/mutex/PgAdvisoryLockMutexTest.php index 5c2b75bf..8c890734 100644 --- a/tests/mutex/PgAdvisoryLockMutexTest.php +++ b/tests/mutex/PgAdvisoryLockMutexTest.php @@ -61,7 +61,7 @@ public function testAcquireLock(): void ) ); - $this->mutex->lock(); + \Closure::bind(static fn ($mutex) => $mutex->lock(), null, PgAdvisoryLockMutex::class)($this->mutex); } public function testReleaseLock(): void @@ -95,6 +95,6 @@ public function testReleaseLock(): void ) ); - $this->mutex->unlock(); + \Closure::bind(static fn ($mutex) => $mutex->unlock(), null, PgAdvisoryLockMutex::class)($this->mutex); } }