fix swift param type

Author: Jamie Hannaford

doc/api-docs/template/sub_param_macros.twig

@@ -26,12 +26,8 @@
             {{ _self.iterate_sub_params(sub_param.properties, 'false', full_name) }}
         {% endif %}
     {% elseif sub_param.type == 'array' %}
-        {% if sub_param.itemSchema is null %}
-            {% set type = 'array' %}
-        {% else %}
-            {% set subType = sub_param.itemSchema.type %}
-            {% set type = 'array of ' ~ subType ~ 's' %}
-        {% endif %}
+        {% set subType = sub_param.itemSchema.type %}
+        {% set type = 'array of ' ~ subType ~ 's' %}
     {% elseif parent_is_array == 'true' %}
         {% set render = 'false' %}
     {% endif %}

src/Common/Api/Parameter.php

@@ -155,7 +155,7 @@ private function stockItemSchema(array $data)
     private function stockProperties(array $data)
     {
         if (isset($data['properties'])) {
-            if (strpos(strtolower($this->name), 'metadata') !== false) {
+            if (stripos($this->name, 'metadata') !== false) {
                 $this->properties = new Parameter($data['properties']);
             } else {
                 foreach ($data['properties'] as $name => $property) {
@@ -251,7 +251,7 @@ private function validateObject($userValues)
      */
     private function getNestedProperty($key)
     {
-        if ($this->name == 'metadata' && $this->properties instanceof Parameter) {
+        if (stripos($this->name, 'metadata') !== false && $this->properties instanceof Parameter) {
             return $this->properties;
         } elseif (isset($this->properties[$key])) {
             return $this->properties[$key];

src/Common/Transport/RequestSerializer.php

@@ -57,7 +57,7 @@ private function stockHeader(Parameter $schema, $paramValue, array &$options)
     {
         $paramName = $schema->getName();
 
-        if (strpos(strtolower($paramName), 'metadata') !== false) {
+        if (stripos($paramName, 'metadata') !== false) {
             return $this->stockMetadataHeader($schema, $paramValue, $options);
         }
 

src/ObjectStore/v1/Params.php

@@ -162,8 +162,11 @@ public function metadata($type, $remove = false)
 
         return [
             'location'    => self::HEADER,
-            'type'        => self::ARRAY_TYPE,
+            'type'        => self::OBJECT_TYPE,
             'prefix'      => sprintf("X-%s-Meta-", ucfirst($type)),
+            'properties'  => [
+                'type' => self::STRING_TYPE,
+            ],
             'description' => <<<EOT
 Human-readable key/value pairs that help describe and determine what type of resource it is. You can specify whichever
 key you like, but the values need to be in scalar form (since they will be translated to strings).