Merge pull request #193 from nicolasmure/fix/metadata-parsing

fix metadata header parsing

Author: haphan

src/ObjectStore/v1/Models/MetadataTrait.php

@@ -11,9 +11,9 @@ public function parseMetadata(ResponseInterface $response): array
         $metadata = [];
 
         foreach ($response->getHeaders() as $header => $value) {
-            $position = strpos($header, static::METADATA_PREFIX);
-            if ($position === 0) {
-                $metadata[ltrim($header, static::METADATA_PREFIX)] = $response->getHeader($header)[0];
+            if (0 === strpos($header, static::METADATA_PREFIX)) {
+                $name = substr($header, strlen(static::METADATA_PREFIX));
+                $metadata[$name] = $response->getHeader($header)[0];
             }
         }
 

tests/unit/ObjectStore/v1/Fixtures/HEAD_Object.resp

@@ -5,6 +5,7 @@ Last-Modified: Thu, 16 Jan 2014 21:12:31 GMT
 Etag: 451e372e48e0f6b1114fa0724aa79fa1
 X-Timestamp: 1389906751.73463
 X-Object-Meta-Book: GoodbyeColumbus
+X-Object-Meta-Manufacturer: Acme
 Content-Type: application/octet-stream
 X-Trans-Id: tx37ea34dcd1ed48ca9bc7d-0052d84b6f
-Date: Thu, 16 Jan 2014 21:13:19 GMT
+Date: Thu, 16 Jan 2014 21:13:19 GMT

tests/unit/ObjectStore/v1/Models/ObjectTest.php

@@ -66,16 +66,20 @@ public function test_Get_Metadata()
     {
         $this->setupMock('HEAD', self::CONTAINER . '/' . self::NAME, null, [], 'HEAD_Object');
 
-        $this->assertEquals(['Book' => 'GoodbyeColumbus'], $this->object->getMetadata());
+        $this->assertEquals([
+            'Book'         => 'GoodbyeColumbus',
+            'Manufacturer' => 'Acme',
+        ], $this->object->getMetadata());
     }
 
     public function test_Merge_Metadata()
     {
         $this->setupMock('HEAD', self::CONTAINER . '/' . self::NAME, null, [], 'HEAD_Object');
 
         $headers = [
-            'X-Object-Meta-Author' => 'foo',
-            'X-Object-Meta-Book'   => 'GoodbyeColumbus',
+            'X-Object-Meta-Author'       => 'foo',
+            'X-Object-Meta-Book'         => 'GoodbyeColumbus',
+            'X-Object-Meta-Manufacturer' => 'Acme',
         ];
 
         $this->setupMock('POST', self::CONTAINER . '/' . self::NAME, null, $headers, 'NoContent');