From 3c9f076c7f55570476c6cc021790d2279c731aea Mon Sep 17 00:00:00 2001 From: Sam Date: Thu, 2 Jun 2022 11:15:39 +0200 Subject: [PATCH 1/7] Better return types for `getBackingType` The only backing types for Enums are `int` and `string`. The proper return type for `ReflectionEnum::getBackingType()` is thus `null|ReflectionNamedType`. --- reference/reflection/reflectionenum/getbackingtype.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index 40a7cb400c02..3beea5794b28 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -8,12 +8,12 @@ &reftitle.description; - public ReflectionTypenullReflectionEnum::getBackingType + public ReflectionNamedTypenullReflectionEnum::getBackingType If the enumeration is a Backed Enum, this method will return an instance - of ReflectionType for the backing type of the Enum. + of ReflectionNamedType for the backing type of the Enum. If it is not a Backed Enum, it will return null. @@ -27,7 +27,7 @@ &reftitle.returnvalues; - An instance of ReflectionType, or null + An instance of ReflectionNamedType, or null if the Enum has no backing type. From 353758564f36e401a4e3e33bd262b43be71c07c8 Mon Sep 17 00:00:00 2001 From: Sam Mousa Date: Fri, 3 Jun 2022 10:17:50 +0200 Subject: [PATCH 2/7] chore: add changelog entry --- .../reflectionenum/getbackingtype.xml | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index 3beea5794b28..be5b511f0eda 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -65,7 +65,27 @@ string(6) "string" - + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.2.0 + + The declared return type was narrowed to ReflectionNamedType from ReflectionType. + + + + + + &reftitle.seealso; From 19b2e57e521802ef9436b034d85bd95d5f0ca7d2 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 6 Jun 2022 15:36:39 +0200 Subject: [PATCH 3/7] Update reference/reflection/reflectionenum/getbackingtype.xml Co-authored-by: Christoph M. Becker --- reference/reflection/reflectionenum/getbackingtype.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index be5b511f0eda..370f04085f3e 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -65,7 +65,7 @@ string(6) "string" - + &reftitle.changelog; From fa57d7808fce47a271c1d3dea556149562043c4f Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 6 Jun 2022 15:36:46 +0200 Subject: [PATCH 4/7] Update reference/reflection/reflectionenum/getbackingtype.xml Co-authored-by: Christoph M. Becker --- reference/reflection/reflectionenum/getbackingtype.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index 370f04085f3e..3d60bc95efc6 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -85,7 +85,7 @@ string(6) "string" - + &reftitle.seealso; From ca27c0a85fae467572d371169d223a28b80fa0e1 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 6 Jun 2022 15:36:54 +0200 Subject: [PATCH 5/7] Update reference/reflection/reflectionenum/getbackingtype.xml Co-authored-by: Christoph M. Becker --- reference/reflection/reflectionenum/getbackingtype.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index 3d60bc95efc6..9f690b12d9a1 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -79,7 +79,8 @@ string(6) "string" 8.2.0 - The declared return type was narrowed to ReflectionNamedType from ReflectionType. + The declared return type was narrowed to ReflectionNamedType + from ReflectionType. From 3c9b2c7e69877219e1077aa78a86b4767df44d5e Mon Sep 17 00:00:00 2001 From: Sam Mousa Date: Wed, 15 Jun 2022 13:26:56 +0200 Subject: [PATCH 6/7] fix: changelog before examples --- .../reflectionenum/getbackingtype.xml | 45 +++++++++---------- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index 9f690b12d9a1..aa01fc04d134 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -31,7 +31,28 @@ if the Enum has no backing type. - + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.2.0 + + The declared return type was narrowed to ReflectionNamedType + from ReflectionType. + + + + + + &reftitle.examples; @@ -65,28 +86,6 @@ string(6) "string" - - &reftitle.changelog; - - - - - &Version; - &Description; - - - - - 8.2.0 - - The declared return type was narrowed to ReflectionNamedType - from ReflectionType. - - - - - - &reftitle.seealso; From 816d2d0a99a996fe28cb363da7abfeb12f3942f5 Mon Sep 17 00:00:00 2001 From: Sam Date: Wed, 22 Jun 2022 15:57:24 +0200 Subject: [PATCH 7/7] Update reference/reflection/reflectionenum/getbackingtype.xml Co-authored-by: Sergey Panteleev --- reference/reflection/reflectionenum/getbackingtype.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/reference/reflection/reflectionenum/getbackingtype.xml b/reference/reflection/reflectionenum/getbackingtype.xml index aa01fc04d134..8977286c7699 100644 --- a/reference/reflection/reflectionenum/getbackingtype.xml +++ b/reference/reflection/reflectionenum/getbackingtype.xml @@ -86,6 +86,7 @@ string(6) "string" + &reftitle.seealso;