From 95aeebf748a3f86a2c71d2dedb08f4fb782ed7d0 Mon Sep 17 00:00:00 2001
From: Yoshinari Takaoka <mumumu@mumumu.org>
Date: Sun, 5 Nov 2023 10:58:37 +0900
Subject: [PATCH] [PHP 8.3] Calling Phar::setStub() with a resource and a
 $length is now deprecated.

---
 appendices/migration83/deprecated.xml |  2 +-
 reference/phar/Phar/setStub.xml       | 31 ++++++++++++++++++++++++---
 2 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/appendices/migration83/deprecated.xml b/appendices/migration83/deprecated.xml
index 3b271ae26cad..ab65272d82a8 100644
--- a/appendices/migration83/deprecated.xml
+++ b/appendices/migration83/deprecated.xml
@@ -92,7 +92,7 @@
 
   <para>
    Calling <methodname>Phar::setStub</methodname> with a
-   <parameter>$resource</parameter> and a <parameter>$length</parameter>
+   <type>resource</type> and a <parameter>$length</parameter>
    is now deprecated. Such calls should be replaced by:
    <code>$phar->setStub(stream_get_contents($resource));</code>
   </para>
diff --git a/reference/phar/Phar/setStub.xml b/reference/phar/Phar/setStub.xml
index 694e52726485..c369e22b4d43 100644
--- a/reference/phar/Phar/setStub.xml
+++ b/reference/phar/Phar/setStub.xml
@@ -9,8 +9,8 @@
   &reftitle.description;
   <methodsynopsis role="Phar">
    <modifier>public</modifier> <type>bool</type><methodname>Phar::setStub</methodname>
-   <methodparam><type>string</type><parameter>stub</parameter></methodparam>
-   <methodparam choice="opt"><type>int</type><parameter>len</parameter><initializer>-1</initializer></methodparam>
+   <methodparam><type class="union"><type>resource</type><type>string</type></type><parameter>stub</parameter></methodparam>
+   <methodparam choice="opt"><type>int</type><parameter>length</parameter><initializer>-1</initializer></methodparam>
   </methodsynopsis>
   &phar.write;
 
@@ -58,7 +58,7 @@ include 'phar://myphar.phar/somefile.php';
      </listitem>
     </varlistentry>
     <varlistentry>
-     <term><parameter>len</parameter></term>
+     <term><parameter>length</parameter></term>
      <listitem>
       <para>
        
@@ -87,6 +87,31 @@ include 'phar://myphar.phar/somefile.php';
   </para>
  </refsect1>
 
+ <refsect1 role="changelog">
+  &reftitle.changelog;
+  <informaltable>
+   <tgroup cols="2">
+    <thead>
+     <row>
+      <entry>&Version;</entry>
+      <entry>&Description;</entry>
+     </row>
+    </thead>
+    <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       Calling <methodname>Phar::setStub</methodname> with a
+       <type>resource</type> and a <parameter>length</parameter>
+       is now deprecated. Such calls should be replaced by:
+       <code>$phar->setStub(stream_get_contents($resource));</code>
+      </entry>
+     </row>
+    </tbody>
+   </tgroup>
+  </informaltable>
+ </refsect1>
+
  <refsect1 role="examples">
   &reftitle.examples;
   <para>