From 59ede1fd5d035ff0f0dfa714d654e9cd40f323cb Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 2 Dec 2023 13:46:43 +0100 Subject: [PATCH 1/4] Document BC break changes to DOMChildNode --- reference/dom/domcharacterdata/after.xml | 1 + reference/dom/domcharacterdata/before.xml | 1 + .../dom/domcharacterdata/replacewith.xml | 1 + reference/dom/domchildnode/after.xml | 23 +++++++++++++++++++ reference/dom/domchildnode/before.xml | 23 +++++++++++++++++++ reference/dom/domchildnode/replacewith.xml | 23 +++++++++++++++++++ reference/dom/domelement/after.xml | 1 + reference/dom/domelement/before.xml | 1 + reference/dom/domelement/replacewith.xml | 1 + 9 files changed, 75 insertions(+) diff --git a/reference/dom/domcharacterdata/after.xml b/reference/dom/domcharacterdata/after.xml index 81ec1448e49a..00e7714810fb 100644 --- a/reference/dom/domcharacterdata/after.xml +++ b/reference/dom/domcharacterdata/after.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domcharacterdata/before.xml b/reference/dom/domcharacterdata/before.xml index 5a37b1b0de2d..fb2dac93161b 100644 --- a/reference/dom/domcharacterdata/before.xml +++ b/reference/dom/domcharacterdata/before.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domcharacterdata/replacewith.xml b/reference/dom/domcharacterdata/replacewith.xml index be2d2e9b8f92..221fe1483b1b 100644 --- a/reference/dom/domcharacterdata/replacewith.xml +++ b/reference/dom/domcharacterdata/replacewith.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domchildnode/after.xml b/reference/dom/domchildnode/after.xml index 1844c0a95244..635e87d4d790 100644 --- a/reference/dom/domchildnode/after.xml +++ b/reference/dom/domchildnode/after.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.seealso; diff --git a/reference/dom/domchildnode/before.xml b/reference/dom/domchildnode/before.xml index 236f14014471..c84773a53775 100644 --- a/reference/dom/domchildnode/before.xml +++ b/reference/dom/domchildnode/before.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.seealso; diff --git a/reference/dom/domchildnode/replacewith.xml b/reference/dom/domchildnode/replacewith.xml index f94e40826a33..d4253ffe4816 100644 --- a/reference/dom/domchildnode/replacewith.xml +++ b/reference/dom/domchildnode/replacewith.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.seealso; diff --git a/reference/dom/domelement/after.xml b/reference/dom/domelement/after.xml index de644572204b..eac58a593af9 100644 --- a/reference/dom/domelement/after.xml +++ b/reference/dom/domelement/after.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domelement/before.xml b/reference/dom/domelement/before.xml index 51509481ea8d..c51c2c788646 100644 --- a/reference/dom/domelement/before.xml +++ b/reference/dom/domelement/before.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domelement/replacewith.xml b/reference/dom/domelement/replacewith.xml index 7ce4ee0d6f55..b116a27423e9 100644 --- a/reference/dom/domelement/replacewith.xml +++ b/reference/dom/domelement/replacewith.xml @@ -19,6 +19,7 @@ + &reftitle.examples; From 1ad3b10c7954aaf0989472e334e5db666837ccfc Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 2 Dec 2023 13:52:43 +0100 Subject: [PATCH 2/4] Document BC break changes to DOMChildNode and DOMParentNode --- reference/dom/domchildnode/after.xml | 7 ++++++ reference/dom/domdocument/append.xml | 1 + reference/dom/domdocument/prepend.xml | 1 + reference/dom/domdocument/replacechildren.xml | 1 + reference/dom/domdocumentfragment/append.xml | 1 + reference/dom/domdocumentfragment/prepend.xml | 1 + .../domdocumentfragment/replacechildren.xml | 1 + reference/dom/domelement/append.xml | 1 + reference/dom/domelement/prepend.xml | 1 + reference/dom/domelement/replacechildren.xml | 1 + reference/dom/domparentnode/append.xml | 23 +++++++++++++++++++ reference/dom/domparentnode/prepend.xml | 23 +++++++++++++++++++ .../dom/domparentnode/replacechildren.xml | 23 +++++++++++++++++++ 13 files changed, 85 insertions(+) diff --git a/reference/dom/domchildnode/after.xml b/reference/dom/domchildnode/after.xml index 635e87d4d790..4caf40202c33 100644 --- a/reference/dom/domchildnode/after.xml +++ b/reference/dom/domchildnode/after.xml @@ -66,6 +66,13 @@ Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + 8.3.0 + + Calling this method on a node without an owner document now works. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + diff --git a/reference/dom/domdocument/append.xml b/reference/dom/domdocument/append.xml index 2a621b801c45..fde57677de18 100644 --- a/reference/dom/domdocument/append.xml +++ b/reference/dom/domdocument/append.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domdocument/prepend.xml b/reference/dom/domdocument/prepend.xml index 26d2ee3a7be1..76b9482f1c09 100644 --- a/reference/dom/domdocument/prepend.xml +++ b/reference/dom/domdocument/prepend.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domdocument/replacechildren.xml b/reference/dom/domdocument/replacechildren.xml index a31a0d002656..f6542977c935 100644 --- a/reference/dom/domdocument/replacechildren.xml +++ b/reference/dom/domdocument/replacechildren.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domdocumentfragment/append.xml b/reference/dom/domdocumentfragment/append.xml index 262ec46fa946..40c82fd477f9 100644 --- a/reference/dom/domdocumentfragment/append.xml +++ b/reference/dom/domdocumentfragment/append.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domdocumentfragment/prepend.xml b/reference/dom/domdocumentfragment/prepend.xml index 626edf014f6a..bd6692198abb 100644 --- a/reference/dom/domdocumentfragment/prepend.xml +++ b/reference/dom/domdocumentfragment/prepend.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domdocumentfragment/replacechildren.xml b/reference/dom/domdocumentfragment/replacechildren.xml index 455be627111e..8d81d454f67c 100644 --- a/reference/dom/domdocumentfragment/replacechildren.xml +++ b/reference/dom/domdocumentfragment/replacechildren.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domelement/append.xml b/reference/dom/domelement/append.xml index e74d8fc2af6b..bcd3e8adb9a6 100644 --- a/reference/dom/domelement/append.xml +++ b/reference/dom/domelement/append.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domelement/prepend.xml b/reference/dom/domelement/prepend.xml index 790a45e183a7..3ed578f594fc 100644 --- a/reference/dom/domelement/prepend.xml +++ b/reference/dom/domelement/prepend.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domelement/replacechildren.xml b/reference/dom/domelement/replacechildren.xml index facdf5944b08..9b3ebae53adb 100644 --- a/reference/dom/domelement/replacechildren.xml +++ b/reference/dom/domelement/replacechildren.xml @@ -19,6 +19,7 @@ + &reftitle.examples; diff --git a/reference/dom/domparentnode/append.xml b/reference/dom/domparentnode/append.xml index b0e27831b9f9..d2403e2bb8e8 100644 --- a/reference/dom/domparentnode/append.xml +++ b/reference/dom/domparentnode/append.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without an owner document now works. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.seealso; diff --git a/reference/dom/domparentnode/prepend.xml b/reference/dom/domparentnode/prepend.xml index 8f3a66ad76ca..b1205a115857 100644 --- a/reference/dom/domparentnode/prepend.xml +++ b/reference/dom/domparentnode/prepend.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without an owner document now works. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.seealso; diff --git a/reference/dom/domparentnode/replacechildren.xml b/reference/dom/domparentnode/replacechildren.xml index bfd21197e07f..2ab332d201fd 100644 --- a/reference/dom/domparentnode/replacechildren.xml +++ b/reference/dom/domparentnode/replacechildren.xml @@ -48,6 +48,29 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method on a node without an owner document now works. + Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + + + + + + + &reftitle.examples; From 326413f1468f6cd977c367dd9d18ee20b71e6103 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 2 Dec 2023 13:59:30 +0100 Subject: [PATCH 3/4] Document BC break changes to createAttributeNs --- .../dom/domdocument/createattributens.xml | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/reference/dom/domdocument/createattributens.xml b/reference/dom/domdocument/createattributens.xml index 6717245ad3e6..17696fbc5f47 100644 --- a/reference/dom/domdocument/createattributens.xml +++ b/reference/dom/domdocument/createattributens.xml @@ -73,6 +73,37 @@ + + &reftitle.changelog; + + + + + &Version; + &Description; + + + + + 8.3.0 + + Calling this method without specifying a prefix will now choose a prefix instead of assuming the default namespace. + Previously this would create an attribute without a prefix and incorrectly apply the namespace + to the owner element because default namespaces don't apply on attributes. + + + + 8.3.0 + + Calling this method using a prefix that was already declared on the owner element with a different namespace URI + will now change the new prefix to avoid creating namespace conflicts. This aligns the behaviour with the DOM specification. + Previously this threw a DOMException with code DOM_NAMESPACE_ERR. + + + + + + &reftitle.seealso; From bc070f18b79690cec7275caf986851ee84ba362e Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 2 Dec 2023 17:42:55 +0100 Subject: [PATCH 4/4] Use entity for common DOM_HIERARCHY_REQUEST_ERR text --- language-snippets.ent | 4 ++++ reference/dom/domchildnode/after.xml | 4 ++-- reference/dom/domchildnode/before.xml | 2 +- reference/dom/domchildnode/replacewith.xml | 2 +- reference/dom/domparentnode/append.xml | 2 +- reference/dom/domparentnode/prepend.xml | 2 +- reference/dom/domparentnode/replacechildren.xml | 2 +- 7 files changed, 11 insertions(+), 7 deletions(-) diff --git a/language-snippets.ent b/language-snippets.ent index 2b8272e395b1..89c8ce402104 100644 --- a/language-snippets.ent +++ b/language-snippets.ent @@ -1619,6 +1619,10 @@ it is inserted with (e.g.) DOMNo '> +DOMException with code + DOM_HIERARCHY_REQUEST_ERR.'> + Upon failure, an E_WARNING is emitted. diff --git a/reference/dom/domchildnode/after.xml b/reference/dom/domchildnode/after.xml index 4caf40202c33..d3e071ba800d 100644 --- a/reference/dom/domchildnode/after.xml +++ b/reference/dom/domchildnode/after.xml @@ -63,14 +63,14 @@ 8.3.0 Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; 8.3.0 Calling this method on a node without an owner document now works. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; diff --git a/reference/dom/domchildnode/before.xml b/reference/dom/domchildnode/before.xml index c84773a53775..699b87e3fd8c 100644 --- a/reference/dom/domchildnode/before.xml +++ b/reference/dom/domchildnode/before.xml @@ -63,7 +63,7 @@ 8.3.0 Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; diff --git a/reference/dom/domchildnode/replacewith.xml b/reference/dom/domchildnode/replacewith.xml index d4253ffe4816..29f5caf82fa6 100644 --- a/reference/dom/domchildnode/replacewith.xml +++ b/reference/dom/domchildnode/replacewith.xml @@ -63,7 +63,7 @@ 8.3.0 Calling this method on a node without a parent is now a no-op to align the behaviour with the DOM specification. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; diff --git a/reference/dom/domparentnode/append.xml b/reference/dom/domparentnode/append.xml index d2403e2bb8e8..08c7a589d226 100644 --- a/reference/dom/domparentnode/append.xml +++ b/reference/dom/domparentnode/append.xml @@ -63,7 +63,7 @@ 8.3.0 Calling this method on a node without an owner document now works. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; diff --git a/reference/dom/domparentnode/prepend.xml b/reference/dom/domparentnode/prepend.xml index b1205a115857..624f91efbdad 100644 --- a/reference/dom/domparentnode/prepend.xml +++ b/reference/dom/domparentnode/prepend.xml @@ -63,7 +63,7 @@ 8.3.0 Calling this method on a node without an owner document now works. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception; diff --git a/reference/dom/domparentnode/replacechildren.xml b/reference/dom/domparentnode/replacechildren.xml index 2ab332d201fd..2f5163775e05 100644 --- a/reference/dom/domparentnode/replacechildren.xml +++ b/reference/dom/domparentnode/replacechildren.xml @@ -63,7 +63,7 @@ 8.3.0 Calling this method on a node without an owner document now works. - Previously this threw a DOMException with code DOM_HIERARCHY_REQUEST_ERR. + &dom.changelog.previous_hierarchy_exception;