From 2abf2d2c6cba341913a08a3150427ea8c5265e99 Mon Sep 17 00:00:00 2001
From: Sergey Panteleev <sergey@php.net>
Date: Wed, 10 Jan 2024 20:17:36 +0300
Subject: [PATCH 1/2] [PHP 8.3] Update `mt-srand` and `srand` functions

---
 reference/random/functions/mt-srand.xml | 9 ++++++++-
 reference/random/functions/srand.xml    | 9 ++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/reference/random/functions/mt-srand.xml b/reference/random/functions/mt-srand.xml
index dead65437188..9826c492a1d0 100644
--- a/reference/random/functions/mt-srand.xml
+++ b/reference/random/functions/mt-srand.xml
@@ -9,7 +9,7 @@
   &reftitle.description;
   <methodsynopsis>
    <type>void</type><methodname>mt_srand</methodname>
-   <methodparam choice="opt"><type>int</type><parameter>seed</parameter><initializer>0</initializer></methodparam>
+   <methodparam choice="opt"><type class="union"><type>int</type><type>null</type></type><parameter>seed</parameter><initializer>&null;</initializer></methodparam>
    <methodparam choice="opt"><type>int</type><parameter>mode</parameter><initializer><constant>MT_RAND_MT19937</constant></initializer></methodparam>
   </methodsynopsis>
   <para>
@@ -31,6 +31,7 @@
      <listitem>
       <para>
        An arbitrary <type>int</type> seed value.
+       Passing &null; will generate a random seed.
       </para>
      </listitem>
     </varlistentry>
@@ -77,6 +78,12 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.3.0</entry>
+       <entry>
+        <parameter>seed</parameter> is now nullable.
+       </entry>
+      </row>
       <row>
        <entry>7.1.0</entry>
        <entry>
diff --git a/reference/random/functions/srand.xml b/reference/random/functions/srand.xml
index 4585e07ef0d9..de307f87eed8 100644
--- a/reference/random/functions/srand.xml
+++ b/reference/random/functions/srand.xml
@@ -9,7 +9,7 @@
   &reftitle.description;
    <methodsynopsis>
    <type>void</type><methodname>srand</methodname>
-   <methodparam choice="opt"><type>int</type><parameter>seed</parameter><initializer>0</initializer></methodparam>
+   <methodparam choice="opt"><type class="union"><type>int</type><type>null</type></type><parameter>seed</parameter><initializer>&null;</initializer></methodparam>
    <methodparam choice="opt"><type>int</type><parameter>mode</parameter><initializer><constant>MT_RAND_MT19937</constant></initializer></methodparam>
   </methodsynopsis>
   <para>
@@ -32,6 +32,7 @@
      <listitem>
       <para>
        An arbitrary <type>int</type> seed value.
+       Passing &null; will generate a random seed.
       </para>
      </listitem>
     </varlistentry>
@@ -57,6 +58,12 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.3.0</entry>
+       <entry>
+        <parameter>seed</parameter> is now nullable.
+       </entry>
+      </row>
       <row>
        <entry>7.1.0</entry>
        <entry>

From b4621d3b6356ff004725285cf53fd06901bf2aa1 Mon Sep 17 00:00:00 2001
From: Sergey Panteleev <sergey@php.net>
Date: Wed, 10 Jan 2024 22:21:56 +0300
Subject: [PATCH 2/2] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
---
 reference/random/functions/mt-srand.xml | 9 +++++++--
 reference/random/functions/srand.xml    | 9 +++++++--
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/reference/random/functions/mt-srand.xml b/reference/random/functions/mt-srand.xml
index 9826c492a1d0..08b76123de15 100644
--- a/reference/random/functions/mt-srand.xml
+++ b/reference/random/functions/mt-srand.xml
@@ -30,8 +30,13 @@
      <term><parameter>seed</parameter></term>
      <listitem>
       <para>
-       An arbitrary <type>int</type> seed value.
-       Passing &null; will generate a random seed.
+       Fills the state with values generated with a linear congruential generator
+       that was seeded with <parameter>seed</parameter> interpreted as an unsigned
+       32 bit integer.
+      </para>
+      <para>
+       If <parameter>seed</parameter> is omitted or &null;, a random unsigned
+       32-bit integer will be used.
       </para>
      </listitem>
     </varlistentry>
diff --git a/reference/random/functions/srand.xml b/reference/random/functions/srand.xml
index de307f87eed8..fe088e909c53 100644
--- a/reference/random/functions/srand.xml
+++ b/reference/random/functions/srand.xml
@@ -31,8 +31,13 @@
      <term><parameter>seed</parameter></term>
      <listitem>
       <para>
-       An arbitrary <type>int</type> seed value.
-       Passing &null; will generate a random seed.
+       Fills the state with values generated with a linear congruential generator
+       that was seeded with <parameter>seed</parameter> interpreted as an unsigned
+       32 bit integer.
+      </para>
+      <para>
+       If <parameter>seed</parameter> is omitted or &null;, a random unsigned
+       32-bit integer will be used.
       </para>
      </listitem>
     </varlistentry>