From 44a9e3bd55dc2f23a3479fc238d09939044941cf Mon Sep 17 00:00:00 2001
From: Sergey Panteleev <sergey@php.net>
Date: Sat, 17 Feb 2024 11:33:43 +0300
Subject: [PATCH 1/2] [PHP 8.3] Update PGSQL

---
 reference/pgsql/functions/pg-convert.xml      | 16 ++++++++++++
 reference/pgsql/functions/pg-fetch-object.xml | 16 ++++++++++++
 reference/pgsql/functions/pg-fetch-result.xml |  8 +++++-
 .../pgsql/functions/pg-field-is-null.xml      |  8 +++++-
 reference/pgsql/functions/pg-field-prtlen.xml |  8 +++++-
 reference/pgsql/functions/pg-insert.xml       | 26 +++++++++++++++++++
 6 files changed, 79 insertions(+), 3 deletions(-)

diff --git a/reference/pgsql/functions/pg-convert.xml b/reference/pgsql/functions/pg-convert.xml
index 19dd4c042420..7c56c5314678 100644
--- a/reference/pgsql/functions/pg-convert.xml
+++ b/reference/pgsql/functions/pg-convert.xml
@@ -85,6 +85,14 @@
   </para>
  </refsect1>
 
+ <refsect1 role="errors">
+  &reftitle.errors;
+  <para>
+   A <classname>ValueError</classname> or <classname>TypeError</classname> is thrown
+   when the value or type of field does not match properly with a PostgreSQL's type.
+  </para>
+ </refsect1>
+
  <refsect1 role="changelog">
   &reftitle.changelog;
   <informaltable>
@@ -96,6 +104,14 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       Now throws a <classname>ValueError</classname> or <classname>TypeError</classname> error
+       when the value or type of field does not match properly with a PostgreSQL's type;
+       previously an <constant>E_WARNING</constant> was emitted.
+      </entry>
+     </row>
      &pgsql.changelog.connection-object;
     </tbody>
    </tgroup>
diff --git a/reference/pgsql/functions/pg-fetch-object.xml b/reference/pgsql/functions/pg-fetch-object.xml
index 049b3071f5df..7e82297e9dd4 100644
--- a/reference/pgsql/functions/pg-fetch-object.xml
+++ b/reference/pgsql/functions/pg-fetch-object.xml
@@ -85,6 +85,14 @@
   </para>
  </refsect1>
 
+ <refsect1 role="errors">
+  &reftitle.errors;
+  <para>
+   A <classname>ValueError</classname> is thrown when
+   the <parameter>constructor_args</parameter> is non-empty with the class not having constructor.
+  </para>
+ </refsect1>
+
  <refsect1 role="changelog">
   &reftitle.changelog;
   <informaltable>
@@ -96,6 +104,14 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       Now throws a <classname>ValueError</classname> exception when
+       the <parameter>constructor_args</parameter> is non-empty with the class not having constructor;
+       previously an <classname>Exception</classname> was thrown.
+      </entry>
+     </row>
      &pgsql.changelog.result-object;
     </tbody>
    </tgroup>
diff --git a/reference/pgsql/functions/pg-fetch-result.xml b/reference/pgsql/functions/pg-fetch-result.xml
index bb673910a233..9c3273fdc508 100644
--- a/reference/pgsql/functions/pg-fetch-result.xml
+++ b/reference/pgsql/functions/pg-fetch-result.xml
@@ -12,7 +12,7 @@
   <methodsynopsis>
    <type class="union"><type>string</type><type>false</type><type>null</type></type><methodname>pg_fetch_result</methodname>
    <methodparam><type>PgSql\Result</type><parameter>result</parameter></methodparam>
-   <methodparam><type>int</type><parameter>row</parameter></methodparam>
+   <methodparam><type class="union"><type>string</type><type>false</type><type>null</type></type><parameter>row</parameter></methodparam>
    <methodparam><type>mixed</type><parameter>field</parameter></methodparam>
   </methodsynopsis>
   <methodsynopsis>
@@ -90,6 +90,12 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       The <parameter>row</parameter> parameter is now nullable.
+      </entry>
+     </row>
      &pgsql.changelog.result-object;
     </tbody>
    </tgroup>
diff --git a/reference/pgsql/functions/pg-field-is-null.xml b/reference/pgsql/functions/pg-field-is-null.xml
index a1a763f9646f..9f51d59b08c5 100644
--- a/reference/pgsql/functions/pg-field-is-null.xml
+++ b/reference/pgsql/functions/pg-field-is-null.xml
@@ -12,7 +12,7 @@
   <methodsynopsis>
    <type>int</type><methodname>pg_field_is_null</methodname>
    <methodparam><type>PgSql\Result</type><parameter>result</parameter></methodparam>
-   <methodparam><type>int</type><parameter>row</parameter></methodparam>
+   <methodparam><type class="union"><type>string</type><type>false</type><type>null</type></type><parameter>row</parameter></methodparam>
    <methodparam><type>mixed</type><parameter>field</parameter></methodparam>
   </methodsynopsis>
   <methodsynopsis>
@@ -82,6 +82,12 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       The <parameter>row</parameter> parameter is now nullable.
+      </entry>
+     </row>
      &pgsql.changelog.result-object;
     </tbody>
    </tgroup>
diff --git a/reference/pgsql/functions/pg-field-prtlen.xml b/reference/pgsql/functions/pg-field-prtlen.xml
index 9f5c38144ad3..33de21543e98 100644
--- a/reference/pgsql/functions/pg-field-prtlen.xml
+++ b/reference/pgsql/functions/pg-field-prtlen.xml
@@ -12,7 +12,7 @@
   <methodsynopsis>
    <type>int</type><methodname>pg_field_prtlen</methodname>
    <methodparam><type>PgSql\Result</type><parameter>result</parameter></methodparam>
-   <methodparam><type>int</type><parameter>row_number</parameter></methodparam>
+   <methodparam><type class="union"><type>string</type><type>false</type><type>null</type></type><parameter>row</parameter></methodparam>
    <methodparam><type>mixed</type><parameter>field_name_or_number</parameter></methodparam>
   </methodsynopsis>
   <methodsynopsis>
@@ -83,6 +83,12 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       The <parameter>row</parameter> parameter is now nullable.
+      </entry>
+     </row>
      &pgsql.changelog.result-object;
     </tbody>
    </tgroup>
diff --git a/reference/pgsql/functions/pg-insert.xml b/reference/pgsql/functions/pg-insert.xml
index 054fda48c3cf..a27c40a2583d 100644
--- a/reference/pgsql/functions/pg-insert.xml
+++ b/reference/pgsql/functions/pg-insert.xml
@@ -97,6 +97,17 @@
   </para>
  </refsect1>
 
+ <refsect1 role="errors">
+  &reftitle.errors;
+  <para>
+   A <classname>ValueError</classname> is thrown when the specified table is invalid.
+  </para>
+  <para>
+   A <classname>ValueError</classname> or <classname>TypeError</classname> is thrown
+   when the value or type of field does not match properly with a PostgreSQL's type.
+  </para>
+ </refsect1>
+
  <refsect1 role="changelog">
   &reftitle.changelog;
   <informaltable>
@@ -108,6 +119,21 @@
      </row>
     </thead>
     <tbody>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       Now throws a <classname>ValueError</classname> error when the specified table is invalid;
+       previously an <constant>E_WARNING</constant> was emitted.
+      </entry>
+     </row>
+     <row>
+      <entry>8.3.0</entry>
+      <entry>
+       Now throws a <classname>ValueError</classname> or <classname>TypeError</classname> error
+       when the value or type of field does not match properly with a PostgreSQL's type;
+       previously an <constant>E_WARNING</constant> was emitted.
+      </entry>
+     </row>
      &pgsql.changelog.return-result-object;
      &pgsql.changelog.connection-object;
     </tbody>

From 760d8e4be68c862bab7c6e163243b9a86dab3d5d Mon Sep 17 00:00:00 2001
From: Sergey Panteleev <sergey@php.net>
Date: Sun, 18 Feb 2024 23:06:11 +0300
Subject: [PATCH 2/2] Apply suggestions from code review

Co-authored-by: David CARLIER <devnexen@gmail.com>
---
 reference/pgsql/functions/pg-fetch-result.xml  | 2 +-
 reference/pgsql/functions/pg-field-is-null.xml | 2 +-
 reference/pgsql/functions/pg-field-prtlen.xml  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/reference/pgsql/functions/pg-fetch-result.xml b/reference/pgsql/functions/pg-fetch-result.xml
index 9c3273fdc508..b83d5f874215 100644
--- a/reference/pgsql/functions/pg-fetch-result.xml
+++ b/reference/pgsql/functions/pg-fetch-result.xml
@@ -93,7 +93,7 @@
      <row>
       <entry>8.3.0</entry>
       <entry>
-       The <parameter>row</parameter> parameter is now nullable.
+       <parameter>row</parameter> is now nullable.
       </entry>
      </row>
      &pgsql.changelog.result-object;
diff --git a/reference/pgsql/functions/pg-field-is-null.xml b/reference/pgsql/functions/pg-field-is-null.xml
index 9f51d59b08c5..24bdc102e4a4 100644
--- a/reference/pgsql/functions/pg-field-is-null.xml
+++ b/reference/pgsql/functions/pg-field-is-null.xml
@@ -85,7 +85,7 @@
      <row>
       <entry>8.3.0</entry>
       <entry>
-       The <parameter>row</parameter> parameter is now nullable.
+       <parameter>row</parameter> is now nullable.
       </entry>
      </row>
      &pgsql.changelog.result-object;
diff --git a/reference/pgsql/functions/pg-field-prtlen.xml b/reference/pgsql/functions/pg-field-prtlen.xml
index 33de21543e98..f88d2a466466 100644
--- a/reference/pgsql/functions/pg-field-prtlen.xml
+++ b/reference/pgsql/functions/pg-field-prtlen.xml
@@ -86,7 +86,7 @@
      <row>
       <entry>8.3.0</entry>
       <entry>
-       The <parameter>row</parameter> parameter is now nullable.
+       <parameter>row</parameter> is now nullable.
       </entry>
      </row>
      &pgsql.changelog.result-object;