simple ignore arguments in backtrace implementation

Author: krakjoe

Zend/tests/debug_backtrace_ignore_args.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Exceptions ignoring arguments
+--FILE--
+<?php
+$function = function(string $user, string $pass) {
+    throw new Exception();
+};
+
+ini_set("zend.backtrace_ignore_args", 1);
+
+$function("secrets", "arewrong");
+?>
+--EXPECTF--
+Fatal error: Uncaught Exception in %sdebug_backtrace_ignore_args.php:3
+Stack trace:
+#0 %sdebug_backtrace_ignore_args.php(8): {closure}()
+#1 {main}
+  thrown in %sdebug_backtrace_ignore_args.php on line 3

Zend/tests/debug_backtrace_ignore_args_no_interference.phpt

@@ -0,0 +1,31 @@
+--TEST--
+zend.backtrace_ignore_args does not interfere with debug_backtrace
+--FILE--
+<?php
+$function = function(string $user, string $pass, int $options = 0) {
+    return debug_backtrace($options);
+};
+
+ini_set("zend.backtrace_ignore_args", true);
+
+$trace = $function("user", "pass");
+
+if (!isset($trace[0]["args"])) { # args should exist
+    var_dump($trace);
+    exit;
+}
+
+echo "OK\n";
+
+$trace = $function("user", "pass", DEBUG_BACKTRACE_IGNORE_ARGS);
+
+if (isset($trace[0]["args"])) { # args should be ignored
+    var_dump($trace);
+    exit;
+}
+
+echo "OK\n";
+?>
+--EXPECT--
+OK
+OK

Zend/zend.c

@@ -174,6 +174,7 @@ ZEND_INI_BEGIN()
 #ifdef ZEND_SIGNALS
 	STD_ZEND_INI_BOOLEAN("zend.signal_check", "0", ZEND_INI_SYSTEM, OnUpdateBool, check, zend_signal_globals_t, zend_signal_globals)
 #endif
+    STD_ZEND_INI_BOOLEAN("zend.backtrace_ignore_args",	"0",	ZEND_INI_ALL,		OnUpdateBool, backtrace_ignore_args, zend_executor_globals, executor_globals)
 ZEND_INI_END()
 
 ZEND_API size_t zend_vspprintf(char **pbuf, size_t max_len, const char *format, va_list ap) /* {{{ */

Zend/zend_exceptions.c

@@ -212,7 +212,9 @@ static zend_object *zend_default_exception_new_ex(zend_class_entry *class_type,
 	object_properties_init(object, class_type);
 
 	if (EG(current_execute_data)) {
-		zend_fetch_debug_backtrace(&trace, skip_top_traces, 0, 0);
+		zend_fetch_debug_backtrace(&trace,
+			skip_top_traces,
+			EG(backtrace_ignore_args) ? DEBUG_BACKTRACE_IGNORE_ARGS : 0, 0);
 	} else {
 		array_init(&trace);
 	}

Zend/zend_globals.h

@@ -234,6 +234,8 @@ struct _zend_executor_globals {
 
 	HashTable weakrefs;
 
+    zend_bool backtrace_ignore_args;
+
 	void *reserved[ZEND_MAX_RESERVED_RESOURCES];
 };