This repository was archived by the owner on Jul 24, 2024. It is now read-only.
backup,restore: support backing up / restore system databases (#1048)#1077
Merged
ti-chi-bot merged 4 commits intoMay 11, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
need #1025 |
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 4459e58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #1048 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/1077After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
#872 and #679.
But this doesn't allow restore stats -- because the table IDs of the stats backed up are old table IDs, we need more efforts to rewrite them to make them take effect after the restoration.
What is changed and how it works?
This PR basically implemented #679 (comment), with some difference:
RENAME TABLE temp.xxx TO mysql.xxxwould be used, for effectively restoring user tables created inmysqlschema.-f(the table filter) flag. Users must specify each table they want to restore by the table filter syntax (e.g.br restore full -f '*.*' -f '!mysql.*' -f 'mysql.usertable'to restoremysql.usertable).Check List
Tests
Related changes
Release Note
mysqlschema.