backup,restore: support backing up / restore system databases (#1048)#1078
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
listen tcp 0.0.0.0:10080: bind: address already in use /run-integration-tests |
|
/lgtm |
|
/run-all-tests |
|
/run-integration-tests |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 60f6d11 |
|
/merge |
|
/run-all-tests |
cherry-pick #1048 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/1078After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
#872 and #679.
But this doesn't allow restore stats -- because the table IDs of the stats backed up are old table IDs, we need more efforts to rewrite them to make them take effect after the restoration.
What is changed and how it works?
This PR basically implemented #679 (comment), with some difference:
RENAME TABLE temp.xxx TO mysql.xxxwould be used, for effectively restoring user tables created inmysqlschema.-f(the table filter) flag. Users must specify each table they want to restore by the table filter syntax (e.g.br restore full -f '*.*' -f '!mysql.*' -f 'mysql.usertable'to restoremysql.usertable).Check List
Tests
Related changes
Release Note
mysqlschema.