From c5c1126bb0ac64c10d4b219bd4e546e90649c816 Mon Sep 17 00:00:00 2001 From: Hillium Date: Tue, 14 Jul 2020 15:06:09 +0800 Subject: [PATCH] backup: move some non-fatal error log into warn level --- pkg/backup/push.go | 4 ++-- pkg/backup/safe_point.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/backup/push.go b/pkg/backup/push.go index d329f7088..b94464c62 100644 --- a/pkg/backup/push.go +++ b/pkg/backup/push.go @@ -96,10 +96,10 @@ func (push *pushDown) pushBackup( errPb := resp.GetError() switch v := errPb.Detail.(type) { case *backup.Error_KvError: - log.Error("backup occur kv error", zap.Reflect("error", v)) + log.Warn("backup occur kv error", zap.Reflect("error", v)) case *backup.Error_RegionError: - log.Error("backup occur region error", + log.Warn("backup occur region error", zap.Reflect("error", v)) case *backup.Error_ClusterIdError: diff --git a/pkg/backup/safe_point.go b/pkg/backup/safe_point.go index ae3cb3b50..c39a8921b 100644 --- a/pkg/backup/safe_point.go +++ b/pkg/backup/safe_point.go @@ -68,7 +68,7 @@ func StartServiceSafePointKeeper( updateGapTime := time.Duration(ttl) * time.Second / preUpdateServiceSafePointFactor update := func(ctx context.Context) { if err := UpdateServiceSafePoint(ctx, pdClient, ttl, backupTS); err != nil { - log.Error("failed to update service safe point, backup may fail if gc triggered", + log.Warn("failed to update service safe point, backup may fail if gc triggered", zap.Error(err), ) }