Skip to content

reference: change the description of SQL_MODE#2107

Merged
junlan-zhang merged 5 commits into
pingcap:masterfrom
wshwsh12:sql_mode
Dec 10, 2019
Merged

reference: change the description of SQL_MODE#2107
junlan-zhang merged 5 commits into
pingcap:masterfrom
wshwsh12:sql_mode

Conversation

@wshwsh12
Copy link
Copy Markdown
Contributor

@wshwsh12 wshwsh12 commented Dec 9, 2019

What is changed, added or deleted?

Fix the description of SQL_MODE.
Now TiDB default SQL mode is same with MySQL 5.7, but different of MySQL 8.0.

Which version does your change affect?

dev, v3.0, v3.1, v2.1

@junlan-zhang junlan-zhang self-requested a review December 9, 2019 03:13
@junlan-zhang junlan-zhang added the translation/doing This PR’s assignee is translating this PR. label Dec 9, 2019
Copy link
Copy Markdown
Contributor

@junlan-zhang junlan-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread dev/reference/mysql-compatibility.md Outdated
+ 默认 SQL mode 与 MySQL 不同:
+ TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ MySQL 中默认设置:
+ MySQL 5.7 中与 TiDB 相同
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ MySQL 5.7 中与 TiDB 相同
+ MySQL 5.7 的默认 SQL mode 与 TiDB 相同

Comment thread v2.1/reference/mysql-compatibility.md Outdated
+ 默认 SQL mode 与 MySQL 不同:
+ TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ MySQL 中默认设置:
+ MySQL 5.7 中与 TiDB 相同
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ MySQL 5.7 中与 TiDB 相同
+ MySQL 5.7 的默认 SQL mode 与 TiDB 相同

Comment thread v3.0/reference/mysql-compatibility.md Outdated
+ 默认 SQL mode 与 MySQL 不同:
+ TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ MySQL 中默认设置:
+ MySQL 5.7 中与 TiDB 相同
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ MySQL 5.7 中与 TiDB 相同
+ MySQL 5.7 的默认 SQL mode 与 TiDB 相同

Comment thread v3.1/reference/mysql-compatibility.md Outdated
+ 默认 SQL mode 与 MySQL 不同:
+ TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ MySQL 中默认设置:
+ MySQL 5.7 中与 TiDB 相同
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ MySQL 5.7 中与 TiDB 相同
+ MySQL 5.7 的默认 SQL mode 与 TiDB 相同

@junlan-zhang junlan-zhang self-assigned this Dec 9, 2019
Comment thread dev/reference/mysql-compatibility.md Outdated
+ MySQL 5.7 中该值默认为 `ON`。
+ 默认 SQL mode 与 MySQL **已相同**
+ TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION`
+ 默认 SQL mode 与 MySQL 不同:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与 MySQL 5.7 相同,与 MySQL 8.0 不同

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. @XuHuaiyu PTAL

Copy link
Copy Markdown
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlan-zhang junlan-zhang merged commit b19d577 into pingcap:master Dec 10, 2019
@junlan-zhang junlan-zhang changed the title dev, v2.1, v3.0, v3.1/reference: change the description of SQL_MODE reference: change the description of SQL_MODE Dec 10, 2019
@lilin90 lilin90 added the size/small Changes of a small size. label Dec 17, 2019
@junlan-zhang junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants