reference: change the description of SQL_MODE#2107
Merged
Conversation
junlan-zhang
reviewed
Dec 9, 2019
| + 默认 SQL mode 与 MySQL 不同: | ||
| + TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION` | ||
| + MySQL 中默认设置: | ||
| + MySQL 5.7 中与 TiDB 相同 |
Contributor
There was a problem hiding this comment.
Suggested change
| + MySQL 5.7 中与 TiDB 相同 | |
| + MySQL 5.7 的默认 SQL mode 与 TiDB 相同 |
| + 默认 SQL mode 与 MySQL 不同: | ||
| + TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION` | ||
| + MySQL 中默认设置: | ||
| + MySQL 5.7 中与 TiDB 相同 |
Contributor
There was a problem hiding this comment.
Suggested change
| + MySQL 5.7 中与 TiDB 相同 | |
| + MySQL 5.7 的默认 SQL mode 与 TiDB 相同 |
| + 默认 SQL mode 与 MySQL 不同: | ||
| + TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION` | ||
| + MySQL 中默认设置: | ||
| + MySQL 5.7 中与 TiDB 相同 |
Contributor
There was a problem hiding this comment.
Suggested change
| + MySQL 5.7 中与 TiDB 相同 | |
| + MySQL 5.7 的默认 SQL mode 与 TiDB 相同 |
| + 默认 SQL mode 与 MySQL 不同: | ||
| + TiDB 中为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION` | ||
| + MySQL 中默认设置: | ||
| + MySQL 5.7 中与 TiDB 相同 |
Contributor
There was a problem hiding this comment.
Suggested change
| + MySQL 5.7 中与 TiDB 相同 | |
| + MySQL 5.7 的默认 SQL mode 与 TiDB 相同 |
XuHuaiyu
reviewed
Dec 9, 2019
| + MySQL 5.7 中该值默认为 `ON`。 | ||
| + 默认 SQL mode 与 MySQL **已相同** | ||
| + TiDB 和 MySQL 5.7 中均为 `ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION` | ||
| + 默认 SQL mode 与 MySQL 不同: |
Contributor
There was a problem hiding this comment.
与 MySQL 5.7 相同,与 MySQL 8.0 不同
junlan-zhang
approved these changes
Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
Fix the description of SQL_MODE.
Now TiDB default SQL mode is same with MySQL 5.7, but different of MySQL 8.0.
Which version does your change affect?
dev, v3.0, v3.1, v2.1