tidb-lightning: add glossary#2214
Merged
Merged
Conversation
anotherrachel
added
translation/from-docs
kennytm
reviewed
Feb 10, 2020
yikeke
reviewed
Feb 14, 2020
Contributor
yikeke
left a comment
yikeke
left a comment
There was a problem hiding this comment.
Some links need to be modified. Mostly LGTM. Great job!
Contributor
|
But is it still [DNM]? |
Contributor
Author
Updated the labels. PTAL, thanks! @kennytm |
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
anotherrachel
force-pushed
the
lightning-glossary
branch
from
f5560b8 to
f1db475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
This PR adds a glossary for TiDB-lightning.
What is the related PR or file link(s)?
Which TiDB version(s) does your changes apply to?
Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.