Skip to content

dev/v3.1: move optimizer hints to proper section#2252

Merged
sre-bot merged 5 commits into
pingcap:masterfrom
eurekaka:hint
Feb 28, 2020
Merged

dev/v3.1: move optimizer hints to proper section#2252
sre-bot merged 5 commits into
pingcap:masterfrom
eurekaka:hint

Conversation

@eurekaka
Copy link
Copy Markdown
Contributor

@eurekaka eurekaka commented Feb 18, 2020

What is changed, added or deleted?

No adding or deleting, I moved several optimizer hints from "runtime" chapter to "optimizer" chapter.

What is the related PR or file link(s)?

  • Reference link(s):
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@eurekaka eurekaka added type/refactor The issue belongs to a refactor work. dev v4.0 This PR/issue applies to TiDB v4.0. labels Feb 18, 2020
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @winoros @lzmhhh123

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Feb 21, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Feb 23, 2020

After this PR merges, sre-bot will cherry-pick this PR to the release-3.1 branch (the needs-cherry-pick-3.1 label will trigger this behavior). If you want to make changes to the 3.1 version, please make them in that cherry-picked PR~ @eurekaka

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

Your auto merge job has been accepted, waiting for 2236

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6b42e6a into pingcap:master Feb 28, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.1 failed

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Feb 28, 2020

/run-cherry-picker

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to failed

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Feb 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.1 in PR #2337

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to failed

3 similar comments
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to failed

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to failed

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Feb 28, 2020

cherry pick to failed

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Feb 29, 2020
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 1, 2020
yikeke added a commit that referenced this pull request Mar 2, 2020
* cherry pick #2252 to release-3.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* apply the changes to v3.1

Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/refactor The issue belongs to a refactor work. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants