Skip to content

update TiFlash doc about expr pushdown when TiDB new collation is enabled#3687

Merged
ti-srebot merged 6 commits into
pingcap:masterfrom
windtalker:collation_update
Jun 23, 2020
Merged

update TiFlash doc about expr pushdown when TiDB new collation is enabled#3687
ti-srebot merged 6 commits into
pingcap:masterfrom
windtalker:collation_update

Conversation

@windtalker
Copy link
Copy Markdown
Contributor

@windtalker windtalker commented Jun 16, 2020

What is changed, added or deleted? (Required)

update TiFlash doc about expr pushdown when TiDB new collation is enabled

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

TomShawn
TomShawn reviewed Jun 17, 2020
View reviewed changes
Comment thread tiflash/use-tiflash.md Outdated
@TomShawn TomShawn self-assigned this Jun 17, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 17, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 17, 2020

@windtalker Please involve a technical review.

windtalker and others added 2 commits June 18, 2020 09:23
@windtalker @TomShawn
Update tiflash/use-tiflash.md
768c105 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@windtalker
Merge branch 'master' into collation_update
abede9b
@windtalker windtalker requested a review from zanmato1984 June 18, 2020 01:24
zanmato1984
zanmato1984 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 23, 2020

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 23, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit b55ec26 into pingcap:master Jun 23, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 23, 2020
@windtalker @ti-srebot
cherry pick pingcap#3687 to release-4.0
2429fcc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jun 23, 2020

cherry pick to release-4.0 in PR #3781

TomShawn pushed a commit that referenced this pull request Jun 23, 2020
@ti-srebot @windtalker
cherry pick #3687 to release-4.0 (#3781)
12c7cfa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: xufei <xufei@pingcap.com>
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 23, 2020
@yikeke yikeke assigned yikeke and unassigned TomShawn Jun 23, 2020
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@windtalker @TomShawn @ti-srebot @zanmato1984 @yikeke