Skip to content

tools: add shard table's check by table-rules for diff#3814

Merged
WangXiangUSTC merged 8 commits into
pingcap:masterfrom
WangXiangUSTC:xiang/table_rules
Jul 6, 2020
Merged

tools: add shard table's check by table-rules for diff#3814
WangXiangUSTC merged 8 commits into
pingcap:masterfrom
WangXiangUSTC:xiang/table_rules

Conversation

@WangXiangUSTC
Copy link
Copy Markdown
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 29, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

add shard table's check by table-rules for diff

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@glkappe
Copy link
Copy Markdown
Contributor

glkappe commented Jun 29, 2020

Hi，是否可以添加一个新的架构图，instance-id 不变，加一个的表名。表示上游分表名称不能用正则完美的去匹配，所以才用 table_configs 的方式。明确表示两种类配置的不同和特点。并对当前文档中 table_config 标签 source-tables - table 添加此表名。譬如：增加 instance-id: MySQL-1，table: sbtest-4，以区分于 table: table-0/table-1。

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

WangXiangUSTC commented Jul 1, 2020

Hi，是否可以添加一个新的架构图，instance-id 不变，加一个的表名。表示上游分表名称不能用正则完美的去匹配，所以才用 table_configs 的方式。明确表示两种类配置的不同和特点。并对当前文档中 table_config 标签 source-tables - table 添加此表名。譬如：增加 instance-id: MySQL-1，table: sbtest-4，以区分于 table: table-0/table-1。

更新了，效果可以看 https://github.com/WangXiangUSTC/docs-cn/blob/xiang/table_rules/sync-diff-inspector/shard-diff.md

@glkappe
Copy link
Copy Markdown
Contributor

glkappe commented Jul 1, 2020

Hi，是否可以添加一个新的架构图，instance-id 不变，加一个的表名。表示上游分表名称不能用正则完美的去匹配，所以才用 table_configs 的方式。明确表示两种类配置的不同和特点。并对当前文档中 table_config 标签 source-tables - table 添加此表名。譬如：增加 instance-id: MySQL-1，table: sbtest-4，以区分于 table: table-0/table-1。

更新了，效果可以看 https://github.com/WangXiangUSTC/docs-cn/blob/xiang/table_rules/sync-diff-inspector/shard-diff.md

OK

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

WangXiangUSTC commented Jul 6, 2020

@GMHDBJD PTAL

@kissmydb kissmydb requested review from glkappe, kissmydb and yikeke July 6, 2020 06:42
yikeke
yikeke reviewed Jul 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ti-srebot
ti-srebot approved these changes Jul 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

@yikeke,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@yikeke yikeke added size/medium Changes of a medium size. translation/doing This PR’s assignee is translating this PR. labels Jul 6, 2020
@yikeke yikeke self-assigned this Jul 6, 2020
@WangXiangUSTC WangXiangUSTC merged commit bdaa075 into pingcap:master Jul 6, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/table_rules branch July 6, 2020 08:02
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 6, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#3814 to release-2.1
a390b5d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

cherry pick to release-2.1 in PR #3894

@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
5 tasks
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 6, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#3814 to release-3.0
f19b753 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

cherry pick to release-3.0 in PR #3895

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 6, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#3814 to release-3.1
40155ed 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

cherry pick to release-3.1 in PR #3896

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 6, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#3814 to release-4.0
de88642 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
5 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 6, 2020

cherry pick to release-4.0 in PR #3897

ti-srebot added a commit that referenced this pull request Jul 7, 2020
@ti-srebot @WangXiangUSTC
tools: add shard table's check by table-rules for diff (#3814) (#3894)
12ca00d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
ti-srebot added a commit that referenced this pull request Jul 7, 2020
@ti-srebot @WangXiangUSTC
tools: add shard table's check by table-rules for diff (#3814) (#3896)
58f4004 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
TomShawn added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @WangXiangUSTC @TomShawn
cherry pick #3814 to release-3.0 (#3895)
4817ab0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @WangXiangUSTC @TomShawn
cherry pick #3814 to release-4.0 (#3897)
274113b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke yikeke assigned Joyinqin and unassigned yikeke Jul 28, 2020
This was referenced Jul 29, 2020
Merged
Merged
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Jul 30, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jul 30, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Jul 30, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Jul 30, 2020
This was referenced Aug 4, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@kissmydb kissmydb Awaiting requested review from kissmydb

@glkappe glkappe Awaiting requested review from glkappe

+1 more reviewer

@yikeke yikeke yikeke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WangXiangUSTC @glkappe @ti-srebot @Joyinqin @yikeke