Skip to content

dumpling: update table-filter doc#6058

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
lichunzhu:updateTableFilterDoc
Apr 25, 2021
Merged

dumpling: update table-filter doc#6058
ti-chi-bot merged 2 commits into
pingcap:masterfrom
lichunzhu:updateTableFilterDoc

Conversation

@lichunzhu
Copy link
Copy Markdown
Contributor

@lichunzhu lichunzhu commented Apr 19, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

close pingcap/dumpling#268
Update dumpling's description about behaviors about table-filter.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 19, 2021 08:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/cc @cyliu0

@ti-chi-bot ti-chi-bot requested a review from cyliu0 April 19, 2021 09:15
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL
/translation doing
/assign @Liuxiaozhen12

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Apr 19, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

@TomShawn: GitHub didn't allow me to assign the following users: Liuxiaozhen12.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL
/translation doing
/assign @Liuxiaozhen12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/assign Joyinqin

@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Apr 25, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Apr 25, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Apr 25, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Apr 25, 2021

/unassign Joyinqin
/assign

@ti-chi-bot ti-chi-bot assigned Liuxiaozhen12 and unassigned Joyinqin Apr 25, 2021
TomShawn
TomShawn reviewed Apr 25, 2021
View reviewed changes
Comment thread dumpling-overview.md Outdated
@lichunzhu @TomShawn
Update dumpling-overview.md
e0b67b3 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@glorv
Copy link
Copy Markdown
Contributor

glorv commented Apr 25, 2021

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 25, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e0b67b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit 3c34107 into pingcap:master Apr 25, 2021
@lichunzhu lichunzhu deleted the updateTableFilterDoc branch April 25, 2021 07:26
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@lichunzhu @ti-srebot
cherry pick pingcap#6058 to release-4.0
80de693 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 25, 2021

cherry pick to release-4.0 in PR #6145

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@lichunzhu @ti-srebot
cherry pick pingcap#6058 to release-5.0
168f591 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 25, 2021

cherry pick to release-5.0 in PR #6146

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
dumpling: update table-filter doc (#6058) (#6146)
500dbb5
ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
dumpling: update table-filter doc (#6058) (#6145)
2603586
This was referenced Apr 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyliu0 cyliu0 Awaiting requested review from cyliu0

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

there's mysql database generated automatically while using config -f "*.*"

7 participants

@lichunzhu @TomShawn @ti-chi-bot @Liuxiaozhen12 @glorv @ti-srebot @Joyinqin