Skip to content

update doc for Oracle translate function#6788

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
wzru:feat-translate
Aug 6, 2021
Merged

update doc for Oracle translate function#6788
ti-chi-bot merged 3 commits into
pingcap:masterfrom
wzru:feat-translate

Conversation

@wzru
Copy link
Copy Markdown
Contributor

@wzru wzru commented Aug 2, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

To add doc for new feature, supporting Oracle translate function

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 2, 2021 07:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2021
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. v5.2 This PR/issue applies to TiDB v5.2. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 2, 2021
XuHuaiyu
XuHuaiyu approved these changes Aug 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 4, 2021

@XuHuaiyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Aug 6, 2021
View reviewed changes
Comment thread functions-and-operators/string-functions.md Outdated
TomShawn
TomShawn reviewed Aug 6, 2021
View reviewed changes
Comment thread functions-and-operators/string-functions.md Outdated
TomShawn
TomShawn approved these changes Aug 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 6, 2021

/rebase

wzru and others added 3 commits August 6, 2021 03:28
@wzru @TomShawn
update doc for Oracle translate function
8b21683
@wzru @TomShawn
Update functions-and-operators/string-functions.md
a212ea2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@wzru @TomShawn
Update functions-and-operators/string-functions.md
1fed4c6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 6, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 6, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 6, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1fed4c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@ti-chi-bot ti-chi-bot merged commit 921fa43 into pingcap:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.2 This PR/issue applies to TiDB v5.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wzru @ti-chi-bot @TomShawn @XuHuaiyu