Skip to content

ebnf show variables#17000

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
dveeden:ebnf_show_variables
Apr 10, 2024
Merged

ebnf show variables#17000
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
dveeden:ebnf_show_variables

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 8, 2024

What is changed, added or deleted? (Required)

Closes #16999

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and kennytm April 8, 2024 07:05
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 translation/doing This PR's assignee is translating this PR. labels Apr 8, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Apr 8, 2024
@Oreoxmt Oreoxmt removed their request for review April 8, 2024 07:14
lilin90
lilin90 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 09:09:17.455022755 +0000 UTC m=+867018.982563293: ☑️ agreed by lilin90.

kennytm
kennytm requested changes Apr 9, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-show-variables.md Outdated
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 9, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Apr 9, 2024

@ti-chi-bot I'm pretty sure that's not an LGTM 😕

@dveeden @kennytm
Update sql-statements/sql-statement-show-variables.md
60d64d4 
Co-authored-by: kennytm <kennytm@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 9, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 10, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 10, 2024

@lilin90: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 added the lgtm label Apr 10, 2024
@ti-chi-bot ti-chi-bot Bot merged commit c272615 into pingcap:master Apr 10, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 10, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #17117.

This was referenced Apr 10, 2024
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 10, 2024

In response to a cherrypick label: new pull request created to branch release-8.0: #17118.

ti-chi-bot Bot pushed a commit that referenced this pull request Apr 10, 2024
@ti-chi-bot
ebnf show variables (#17000) (#17118)
90a8414
lilin90 pushed a commit that referenced this pull request Apr 10, 2024
@ti-chi-bot @dveeden @kennytm
ebnf show variables (#17000) (#17117)
630cc73 
* ebnf show variables

* Update sql-statements/sql-statement-show-variables.md

Co-authored-by: kennytm <kennytm@gmail.com>

---------

Co-authored-by: Daniël van Eeden <git@myname.nl>
Co-authored-by: Daniël van Eeden <github@myname.nl>
Co-authored-by: kennytm <kennytm@gmail.com>
@lilin90 lilin90 mentioned this pull request Apr 11, 2024
Merged
17 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 11, 2024
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@lilin90 lilin90

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sql-statements/sql-statement-show-variables.md

5 participants

@dveeden @kennytm @ti-chi-bot @lilin90 @Oreoxmt