Skip to content

ebnf show tables#17068

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:ebnf_show_tables
Apr 15, 2024
Merged

ebnf show tables#17068
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:ebnf_show_tables

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 9, 2024

What is changed, added or deleted? (Required)

Closes #17067

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2024
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 12, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 12, 2024

@hfxsd: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 12, 2024

@hfxsd: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 12, 2024
@hfxsd hfxsd mentioned this pull request Apr 12, 2024
Merged
18 tasks
qiancai
qiancai reviewed Apr 15, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-show-tables.md Outdated
qiancai
qiancai reviewed Apr 15, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-show-tables.md Outdated
qiancai
qiancai approved these changes Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 03:11:48.527810619 +0000 UTC m=+1191170.055351166: ☑️ agreed by hfxsd.
  • 2024-04-15 03:56:42.514596746 +0000 UTC m=+224021.625643196: ☑️ agreed by qiancai.

@hfxsd @qiancai
Apply suggestions from code review
3d5ef18 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Apr 15, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 15, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 2a9c7df into pingcap:master Apr 15, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 15, 2024

In response to a cherrypick label: new pull request created to branch release-8.0: #17187.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
Merged
17 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request Apr 15, 2024
@ti-chi-bot
ebnf show tables (#17068) (#17187)
f9fe458
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 15, 2024
Merged
18 tasks
dveeden added a commit to dveeden/docs that referenced this pull request May 15, 2024
@dveeden
ebnf show tables (pingcap#17068)
d30c9fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels

approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sql-statements/sql-statement-show-tables.md

4 participants

@dveeden @hfxsd @ti-chi-bot @qiancai