Skip to content

reference: update the description of SQL mode#1757

Merged
bb7133 merged 7 commits into
pingcap:masterfrom
junlan-zhang:update-the-description-of-SQL-mode
Jan 16, 2020
Merged

reference: update the description of SQL mode#1757
bb7133 merged 7 commits into
pingcap:masterfrom
junlan-zhang:update-the-description-of-SQL-mode

Conversation

@junlan-zhang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted?

  • Update the description of SQL mode
  • Add a missing paragraph for v2.1
  • Update code block format to better support copy

What is the related PR or file link(s)?

pingcap/docs-cn#2107

Which version does your change affect?

dev, v2.1, v3.0, v3.1

@junlan-zhang junlan-zhang changed the title reference: update the description of SQL mode and add a missing paragraph reference: update the description of SQL mode Jan 9, 2020
@junlan-zhang junlan-zhang requested a review from wshwsh12 January 9, 2020 07:16
@junlan-zhang junlan-zhang added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jan 9, 2020
@junlan-zhang junlan-zhang requested review from bb7133 and lilin90 January 9, 2020 07:38
Copy link
Copy Markdown
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlan-zhang
Copy link
Copy Markdown
Contributor Author

PTAL @lilin90 Thanks~

@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jan 14, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ juliezhang1112
❌ bb7133
You have signed the CLA already but the status is still pending? Let us recheck it.

@bb7133 Please sign the CLA. Thanks!

@bb7133 bb7133 closed this Jan 16, 2020
@bb7133 bb7133 reopened this Jan 16, 2020
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 6930286 into pingcap:master Jan 16, 2020
@junlan-zhang junlan-zhang deleted the update-the-description-of-SQL-mode branch January 16, 2020 06:29
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants