Skip to content

tiup: optimize the structure and content of the deployment doc#2326

Merged
lilin90 merged 6 commits into
pingcap:masterfrom
yikeke:optimize-tiup-deploy-doc
Apr 21, 2020
Merged

tiup: optimize the structure and content of the deployment doc#2326
lilin90 merged 6 commits into
pingcap:masterfrom
yikeke:optimize-tiup-deploy-doc

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Apr 19, 2020

What is changed, added or deleted? (Required)

optimize the structure and content of the deployment doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@yikeke yikeke requested a review from lilin90 April 19, 2020 11:13
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Apr 19, 2020
@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Apr 19, 2020

This PR is waiting on #2291.

@yikeke yikeke marked this pull request as ready for review April 20, 2020 11:30
@yikeke yikeke requested a review from superlzs0476 April 20, 2020 11:30
@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Apr 20, 2020
Comment thread how-to/deploy/orchestrated/tiup.md Outdated
Comment thread how-to/deploy/orchestrated/tiup.md Outdated
yikeke and others added 2 commits April 21, 2020 10:45
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 12bf619 into pingcap:master Apr 21, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 21, 2020
…ap#2326)

* tiup: optimize the structure and content of the deployment doc

* align the rest of the doc

* Apply suggestions from code review

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* fix a link

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-4.0 in PR #2362

lilin90 added a commit that referenced this pull request Apr 21, 2020
#2362)

* tiup: optimize the structure and content of the deployment doc

* align the rest of the doc

* Apply suggestions from code review

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

* fix a link

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@yikeke yikeke deleted the optimize-tiup-deploy-doc branch April 21, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants