Skip to content

auto-increment: improve examples#3860

Merged
TomShawn merged 8 commits into
masterfrom
unknown repository
Sep 11, 2020
Merged

auto-increment: improve examples#3860
TomShawn merged 8 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 10, 2020

What is changed, added or deleted? (Required)

Improve examples for auto_increment. This is a followup to this comment: #3584 (comment)

I describe why one shouldn't rely on "continuous" as a property (this implies no major gaps in the sequence, which is not true). Also why monotonic on a per-server basis, etc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost requested a review from tangenta September 10, 2020 03:25
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 10, 2020

@tangenta this is a followup PR. PTAL, thx :-)

@TomShawn TomShawn self-assigned this Sep 10, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Sep 10, 2020
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
Comment thread auto-increment.md Outdated
Comment thread auto-increment.md Outdated
Comment thread auto-increment.md Outdated
Comment thread auto-increment.md Outdated
Comment thread auto-increment.md Outdated
Comment thread auto-increment.md Outdated
Null not nil and others added 6 commits September 10, 2020 10:21
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 11, 2020
@TomShawn TomShawn merged commit b9c6700 into pingcap:master Sep 11, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3879

ti-srebot added a commit that referenced this pull request Sep 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ghost ghost deleted the auto-inc branch September 11, 2020 02:34
@TomShawn TomShawn removed the translation/doing This PR's assignee is translating this PR. label Sep 14, 2020
@TomShawn TomShawn added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants