auto-increment: improve examples (#3860)#3879
Merged
ti-srebot merged 1 commit intoSep 11, 2020
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
ti-srebot
added
size/medium
TomShawn
approved these changes
Sep 11, 2020
TomShawn
added
the
status/can-merge
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #3860 to release-4.0
What is changed, added or deleted? (Required)
Improve examples for
auto_increment. This is a followup to this comment: #3584 (comment)I describe why one shouldn't rely on "continuous" as a property (this implies no major gaps in the sequence, which is not true). Also why monotonic on a per-server basis, etc.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?