Skip to content

sql-statements: use EBNF to render syntax diagrams for ADD, ALTER and ANALYZE statements (#4722)#4764

Merged
TomShawn merged 2 commits into
pingcap:release-2.1from
ti-srebot:release-2.1-4c603f53ce62
Feb 1, 2021
Merged

sql-statements: use EBNF to render syntax diagrams for ADD, ALTER and ANALYZE statements (#4722)#4764
TomShawn merged 2 commits into
pingcap:release-2.1from
ti-srebot:release-2.1-4c603f53ce62

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Feb 1, 2021

cherry-pick #4722 to release-2.1
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/4764

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/4764:release-2.1-4c603f53ce62

What is changed, added or deleted? (Required)

This PR changes the synopsis sections of ADD, ALTER and ANALYZE statements to use the ```ebnf+diagrm block, replacing the original image-based sqlgrams.

To avoid making one single PR too large, I will open 4-5 follow-up PRs to process sql-statements files in batches. And I will delete all image files in the last PR in case of any display issues.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-2.1 This PR is cherry-picked to release-2.1 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Feb 1, 2021
@ti-srebot ti-srebot requested review from TomShawn and kennytm February 1, 2021 03:17
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@CharLotteiu you're already a collaborator in bot's repo.

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2021
@TomShawn TomShawn merged commit 3694f4a into pingcap:release-2.1 Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-2.1 This PR is cherry-picked to release-2.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants