From 4c406f7b000d21ad3641f6d2d9b2903288911099 Mon Sep 17 00:00:00 2001 From: TomShawn <41534398+TomShawn@users.noreply.github.com> Date: Fri, 12 Mar 2021 18:05:55 +0800 Subject: [PATCH 1/2] benchmark: add description to explain the non-index test result --- benchmark/v4.0-performance-benchmarking-with-tpch.md | 4 ++++ geo-distributed-deployment-topology.md | 2 +- hybrid-deployment-topology.md | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/benchmark/v4.0-performance-benchmarking-with-tpch.md b/benchmark/v4.0-performance-benchmarking-with-tpch.md index cda6ab2b885e4..1cd77f78d81c2 100644 --- a/benchmark/v4.0-performance-benchmarking-with-tpch.md +++ b/benchmark/v4.0-performance-benchmarking-with-tpch.md @@ -163,6 +163,10 @@ To avoid TiKV and TiFlash racing for disk and I/O resources, mount the two NVMe ## Test result +> **Note:** +> +> The tables on which SQL statements are executed in this test only has the primary key and does not have secondary index. Therefore, the test result below is not influenced by index. + | Query ID | v3.0 | v4.0 TiKV Only | v4.0 TiKV/TiFlash Automatically | | :-------- | :----------- | :------------ | :-------------- | | 1 | 7.78 s | 7.45 s | 2.09 s | diff --git a/geo-distributed-deployment-topology.md b/geo-distributed-deployment-topology.md index a8b86df100c74..2dd74ec632681 100644 --- a/geo-distributed-deployment-topology.md +++ b/geo-distributed-deployment-topology.md @@ -37,7 +37,7 @@ This section describes the key parameter configuration of the TiDB geo-distribut - The label configuration: - Since TiKV is deployed across different data centers, if the physical machines go down, the Region Group might lose three of the default five replicas, which causes the cluster unavailability. To address this issue, you can configure the labels to enable the smart scheduling of PD, which ensures that the Region Group does not allow three replicas to be located in TiKV instances on the same machine in the same cabinet of the same data center. + Since TiKV is deployed across different data centers, if the physical machines go down, the Raft Group might lose three of the default five replicas, which causes the cluster unavailability. To address this issue, you can configure the labels to enable the smart scheduling of PD, which ensures that the Raft Group does not allow three replicas to be located in TiKV instances on the same machine in the same cabinet of the same data center. - The TiKV configuration: diff --git a/hybrid-deployment-topology.md b/hybrid-deployment-topology.md index 1fa3d0255abce..370f83f78ed24 100644 --- a/hybrid-deployment-topology.md +++ b/hybrid-deployment-topology.md @@ -69,7 +69,7 @@ This section introduces the key parameters when you deploy multiple instances on - The label scheduling configuration - Since multiple instances of TiKV are deployed on a single machine, if the physical machines go down, the Region Group might lose two of the default three replicas, which causes the cluster unavailability. To address this issue, you can use the label to enable the smart scheduling of PD, which ensures that the Region Group has more than two replicas in multiple TiKV instances on the same machine. + Since multiple instances of TiKV are deployed on a single machine, if the physical machines go down, the Raft Group might lose two of the default three replicas, which causes the cluster unavailability. To address this issue, you can use the label to enable the smart scheduling of PD, which ensures that the Raft Group has more than two replicas in multiple TiKV instances on the same machine. - The TiKV configuration From 89a1df926416733748e9fd17fe2e65d02c43fad6 Mon Sep 17 00:00:00 2001 From: TomShawn <41534398+TomShawn@users.noreply.github.com> Date: Mon, 15 Mar 2021 11:46:15 +0800 Subject: [PATCH 2/2] Update benchmark/v4.0-performance-benchmarking-with-tpch.md Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com> --- benchmark/v4.0-performance-benchmarking-with-tpch.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark/v4.0-performance-benchmarking-with-tpch.md b/benchmark/v4.0-performance-benchmarking-with-tpch.md index 1cd77f78d81c2..801db52f05b69 100644 --- a/benchmark/v4.0-performance-benchmarking-with-tpch.md +++ b/benchmark/v4.0-performance-benchmarking-with-tpch.md @@ -165,7 +165,7 @@ To avoid TiKV and TiFlash racing for disk and I/O resources, mount the two NVMe > **Note:** > -> The tables on which SQL statements are executed in this test only has the primary key and does not have secondary index. Therefore, the test result below is not influenced by index. +> The tables on which SQL statements are executed in this test only have primary keys and do not have secondary indexes. Therefore, the test result below is not influenced by indexes. | Query ID | v3.0 | v4.0 TiKV Only | v4.0 TiKV/TiFlash Automatically | | :-------- | :----------- | :------------ | :-------------- |