Skip to content

update async commit related documentation (#5114)#5131

Merged
ti-chi-bot merged 2 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-8750fd74ea40
Mar 26, 2021
Merged

update async commit related documentation (#5114)#5131
ti-chi-bot merged 2 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-8750fd74ea40

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Mar 26, 2021

cherry-pick #5114 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/5131

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/5131:release-5.0-8750fd74ea40

What is changed, added or deleted? (Required)

TiDB 5.0 GA will not contain configurations related to async commit or 1PC. So they are removed.

And we also introduce a weaker consistency model for transactions. Add documentation about it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. v5.0 This PR/issue applies to TiDB v5.0. labels Mar 26, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@TomShawn you're already a collaborator in bot's repo.

Copy link
Copy Markdown

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5bbe758

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

This PR aligns with pingcap/docs-cn#5814.

@ti-chi-bot ti-chi-bot merged commit 8859bbb into pingcap:release-5.0 Mar 26, 2021
@TomShawn TomShawn deleted the release-5.0-8750fd74ea40 branch March 26, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants