tiup: add 3 docs component-help/prune/upgrade by Joyinqin · Pull Request #5221 · pingcap/docs

Joyinqin · 2021-04-06T10:22:52Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

add 3 docs:

tiup/tiup-component-cluster-help.md
tiup/tiup-component-cluster-prune.md
tiup/tiup-component-cluster-upgrade.md

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: tiup: refactor tiup reference docs-cn#4868
Other reference link(s): tiup: add 3 docs disable/display/list #5176

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Joyinqin · 2021-04-06T10:25:37Z

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation from-docs-cn

Joyinqin · 2021-04-06T10:28:03Z

Waiting for #5176 to merge to fix the dead link.

Joyinqin · 2021-04-06T10:40:28Z

/cc @ran-huang @lucklove

Co-authored-by: Ran <huangran@pingcap.com>

ran-huang · 2021-04-07T03:42:27Z

/label require-LGT1
/hold

ran-huang · 2021-04-07T03:42:42Z

/merge

ti-chi-bot · 2021-04-07T03:42:44Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 7e8bc88

Joyinqin · 2021-04-09T02:27:21Z

@lucklove PTAL, thx~

Joyinqin · 2021-04-13T09:03:42Z

/sig docs
/sig tiup

ran-huang · 2021-04-15T05:51:34Z

/unhold

ran-huang · 2021-04-15T06:23:51Z

/remove-label require-LGT1

ran-huang · 2021-04-15T06:24:12Z

@lucklove PTAL. Thanks!

lucklove · 2021-04-15T07:04:03Z

+
+# tiup cluster prune
+
+When [scaling in the cluster]<!-- (/tiup/tiup-component-cluster-scale-in.md) -->, for some components, TiUP does not immediately stop their services or delete their data. You need to wait for the data scheduling to complete and then manually execute the `tiup cluster prune` command to clean up.


What this mean? Why comment the url?

To avoid ci check. After all prs are merged, we will add the url back.

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

lucklove · 2021-04-15T07:24:59Z

Rest LGTM

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

Joyinqin · 2021-04-15T07:34:23Z

@lucklove comments addressd~

lucklove · 2021-04-15T08:38:12Z

/lgtm

ti-chi-bot · 2021-04-15T08:38:16Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lucklove
ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

ran-huang · 2021-04-15T08:42:54Z

/merge

ti-chi-bot · 2021-04-15T08:42:58Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: c5d1d7f

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-15T08:44:30Z

cherry pick to release-4.0 in PR #5337

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-15T08:45:11Z

cherry pick to release-5.0 in PR #5338

add 3 docs

a760c5f

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2021

Update tiup-component-cluster-upgrade.md

54fd085

ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 6, 2021

ti-chi-bot requested review from lucklove and ran-huang April 6, 2021 10:40

Joyinqin changed the title ~~tiup: add 3 docs~~ tiup: add 3 docs component-help/prune/upgrade Apr 7, 2021

ran-huang reviewed Apr 7, 2021

View reviewed changes

Comment thread tiup/tiup-component-cluster-prune.md Outdated

Comment thread tiup/tiup-component-cluster-upgrade.md Outdated

Comment thread tiup/tiup-component-cluster-upgrade.md Outdated

Comment thread tiup/tiup-component-cluster-upgrade.md Outdated

Apply suggestions from code review

7e8bc88

Co-authored-by: Ran <huangran@pingcap.com>

ran-huang approved these changes Apr 7, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021

ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 7, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021

Merge remote-tracking branch 'upstream/master' into tiup-joyin6

18c082a

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021

Update tiup-component-cluster-upgrade.md

fa4c3a0

ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 13, 2021

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2021

Joyinqin added 2 commits April 15, 2021 13:55

Merge remote-tracking branch 'upstream/master' into tiup-joyin6

eb09510

hide the link

8541fc2

ti-chi-bot removed the require-LGT1 Indicates that the PR requires an LGTM. label Apr 15, 2021

lucklove reviewed Apr 15, 2021

View reviewed changes

Comment thread tiup/tiup-component-cluster-upgrade.md Outdated

Apply suggestions from code review

1887da8

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

lucklove reviewed Apr 15, 2021

View reviewed changes

Comment thread tiup/tiup-component-cluster-upgrade.md Outdated

Apply suggestions from code review

c5d1d7f

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021

ti-chi-bot merged commit 5e6fa6a into pingcap:master Apr 15, 2021

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021

cherry pick pingcap#5221 to release-4.0

13327b6

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 15, 2021

tiup: add 3 docs component-help/prune/upgrade (#5221) #5337

Merged

11 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021

cherry pick pingcap#5221 to release-5.0

5a877ea

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 15, 2021

tiup: add 3 docs component-help/prune/upgrade (#5221) #5338

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021

tiup: add 3 docs component-help/prune/upgrade (#5221) (#5337)

07babc3

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021

tiup: add 3 docs component-help/prune/upgrade (#5221) (#5338)

8b9c93f


		# tiup cluster prune

		When [scaling in the cluster]<!-- (/tiup/tiup-component-cluster-scale-in.md) -->, for some components, TiUP does not immediately stop their services or delete their data. You need to wait for the data scheduling to complete and then manually execute the `tiup cluster prune` command to clean up.

Conversation

Joyinqin commented Apr 6, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Joyinqin commented Apr 6, 2021

Uh oh!

Joyinqin commented Apr 6, 2021

Uh oh!

Joyinqin commented Apr 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ran-huang commented Apr 7, 2021

Uh oh!

ran-huang commented Apr 7, 2021

Uh oh!

ti-chi-bot commented Apr 7, 2021

Uh oh!

Joyinqin commented Apr 9, 2021

Uh oh!

Joyinqin commented Apr 13, 2021

Uh oh!

ran-huang commented Apr 15, 2021

Uh oh!

ran-huang commented Apr 15, 2021

Uh oh!

ran-huang commented Apr 15, 2021

Uh oh!

lucklove Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

Joyinqin Apr 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucklove commented Apr 15, 2021

Uh oh!

Joyinqin commented Apr 15, 2021

Uh oh!

lucklove commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

ran-huang commented Apr 15, 2021

Uh oh!

ti-chi-bot commented Apr 15, 2021

Uh oh!

ti-srebot commented Apr 15, 2021

Uh oh!

ti-srebot commented Apr 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Joyinqin Apr 15, 2021 •

edited

Loading