Skip to content

dumpling: update table-filter.md#5463

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
Liuxiaozhen12:translation
Apr 26, 2021
Merged

dumpling: update table-filter.md#5463
ti-chi-bot merged 6 commits into
pingcap:masterfrom
Liuxiaozhen12:translation

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Apr 25, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Liuxiaozhen12 added 2 commits April 25, 2021 11:05
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 25, 2021 03:18
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Apr 25, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. needs-cherry-pick-5.0 labels Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Apr 25, 2021

/cc @TomShawn

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

@Liuxiaozhen12: The label(s) translation/from-docs cannot be applied, because the repository doesn't have them.

Details

In response to this:

/translation from-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

@Liuxiaozhen12: The label(s) translation/from-docs cannot be applied, because the repository doesn't have them.

Details

In response to this:

/translation from-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Apr 25, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Apr 25, 2021

/retitle dumpling: update table-filter.md

@ti-chi-bot ti-chi-bot changed the title Translation from dumpling: update table-filter dumpling: update table-filter.md Apr 25, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Apr 25, 2021

/unassign Joyinqin
/assign

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/unassign @Liuxiaozhen12

TomShawn
TomShawn reviewed Apr 25, 2021
View reviewed changes
Comment thread dumpling-overview.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 26, 2021

/status require-change

@ti-chi-bot ti-chi-bot added the status/require-change Needs the author to address comments. label Apr 26, 2021
@Liuxiaozhen12 @TomShawn
Update dumpling-overview.md
2af65e5 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 26, 2021

/remove-status require-change
/lgtm

@ti-chi-bot ti-chi-bot removed the status/require-change Needs the author to address comments. label Apr 26, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 26, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2af65e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit 831010f into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5463 to release-4.0
133ea29 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 26, 2021

cherry pick to release-4.0 in PR #5513

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5463 to release-5.0
7c61806 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 26, 2021

cherry pick to release-5.0 in PR #5514

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
dumpling: update table-filter.md (#5463) (#5514)
19fa4df
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
dumpling: update table-filter.md (#5463) (#5513)
9f15bc8
@Liuxiaozhen12 Liuxiaozhen12 deleted the translation branch June 25, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Liuxiaozhen12 @ti-chi-bot @TomShawn @ti-srebot