From 56c686453628397f90d00a8be2783b0e3c8b52e5 Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 1 Sep 2021 18:28:16 -0600 Subject: [PATCH 1/2] system-variables: improve noop functions warning --- system-variables.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system-variables.md b/system-variables.md index 7ed885a357e6c..c2bbf16355026 100644 --- a/system-variables.md +++ b/system-variables.md @@ -596,9 +596,9 @@ Constraint checking is always performed in place for pessimistic transactions (d * `START TRANSACTION READ ONLY` and `SET TRANSACTION READ ONLY` syntax * The `tx_read_only`, `transaction_read_only`, `offline_mode`, `super_read_only` and `read_only` system variables -> **Note:** +> **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. ### tidb_enable_parallel_apply New in v5.0 From f52bee09747371400a8984209d6dfd0eb97f1bce Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 8 Sep 2021 09:15:52 -0600 Subject: [PATCH 2/2] Update system-variables.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> --- system-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-variables.md b/system-variables.md index c2bbf16355026..8e6269152ce29 100644 --- a/system-variables.md +++ b/system-variables.md @@ -598,7 +598,7 @@ Constraint checking is always performed in place for pessimistic transactions (d > **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` is permitted, but the transaction remains in read-write mode. ### tidb_enable_parallel_apply New in v5.0