From 3c31a3fccbee2702bee355e95e055f3fb5fdb3b5 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 2 Sep 2021 17:37:45 +0800 Subject: [PATCH 1/3] sql: fix the correctness problem about kill Signed-off-by: Weizhen Wang --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index b80a04de3c234..9fc11cc9e83c4 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -35,7 +35,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is a different syntax from the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension, which is the same function as the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also From a856eed259638a3a2f8eb4dc46e31d55349a0d84 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 2 Sep 2021 18:21:27 +0800 Subject: [PATCH 2/3] Update sql-statements/sql-statement-kill.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index 9fc11cc9e83c4..033008d8a39f7 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -35,7 +35,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is the same function as the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension, which is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also From 6edc4814b6596dde13d243e67109457c95456b37 Mon Sep 17 00:00:00 2001 From: Enwei Date: Thu, 2 Sep 2021 12:39:12 +0200 Subject: [PATCH 3/3] Update sql-statements/sql-statement-kill.md --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index 033008d8a39f7..20a1f4414ca5a 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -35,7 +35,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension. The feature of this statement is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also