From 1c881a606cb9cfbccdd9f030e07bb286e401a63f Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 1 Sep 2021 18:28:16 -0600 Subject: [PATCH 1/2] system-variables: improve noop functions warning --- system-variables.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system-variables.md b/system-variables.md index 7324eaafabc60..66e95c1a5aa1c 100644 --- a/system-variables.md +++ b/system-variables.md @@ -535,9 +535,9 @@ Constraint checking is always performed in place for pessimistic transactions (d * `LOCK IN SHARE MODE` syntax * `SQL_CALC_FOUND_ROWS` syntax -> **Note:** +> **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. ### tidb_enable_parallel_apply New in v5.0 From 9b68f376f41e5bc0df9a0f74c5797c3a509f5aad Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 8 Sep 2021 09:15:52 -0600 Subject: [PATCH 2/2] Update system-variables.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> --- system-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-variables.md b/system-variables.md index 66e95c1a5aa1c..c6083a3e9411a 100644 --- a/system-variables.md +++ b/system-variables.md @@ -537,7 +537,7 @@ Constraint checking is always performed in place for pessimistic transactions (d > **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` is permitted, but the transaction remains in read-write mode. ### tidb_enable_parallel_apply New in v5.0