From 9c1741feb5e8b947d279ff33d0a6730a3fb9f339 Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 1 Sep 2021 18:28:16 -0600 Subject: [PATCH 1/2] system-variables: improve noop functions warning --- system-variables.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system-variables.md b/system-variables.md index c587dfafd3f92..115113f97ef07 100644 --- a/system-variables.md +++ b/system-variables.md @@ -577,9 +577,9 @@ Constraint checking is always performed in place for pessimistic transactions (d * `START TRANSACTION READ ONLY` and `SET TRANSACTION READ ONLY` syntax * The `tx_read_only`, `transaction_read_only`, `offline_mode`, `super_read_only` and `read_only` system variables -> **Note:** +> **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. ### tidb_enable_parallel_apply New in v5.0 From 4a6fdb74df5768dbb6be98fb38649def72b26929 Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Wed, 8 Sep 2021 09:15:52 -0600 Subject: [PATCH 2/2] Update system-variables.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> --- system-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-variables.md b/system-variables.md index 115113f97ef07..a3e1711ceaf24 100644 --- a/system-variables.md +++ b/system-variables.md @@ -579,7 +579,7 @@ Constraint checking is always performed in place for pessimistic transactions (d > **Warning:** > -> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` will be permitted, but transactions will remain in read-write mode. +> Only the default value of `OFF` can be considered safe. Setting `tidb_enable_noop_functions=1` might lead to unexpected behaviors in your application, because it permits TiDB to ignore certain syntax without providing an error. For example, the syntax `START TRANSACTION READ ONLY` is permitted, but the transaction remains in read-write mode. ### tidb_enable_parallel_apply New in v5.0