From 0ff9564a1c3f4b7b680ee1af63376252aaea9c4a Mon Sep 17 00:00:00 2001 From: Ti Chi Robot Date: Fri, 1 Apr 2022 15:56:30 +0800 Subject: [PATCH 1/3] fix typo in placement rules (#8011) (#8021) --- placement-rules-in-sql.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/placement-rules-in-sql.md b/placement-rules-in-sql.md index c1099b1b1ea92..4fda889f20992 100644 --- a/placement-rules-in-sql.md +++ b/placement-rules-in-sql.md @@ -127,7 +127,7 @@ In addition to the placement options above, you can also use the advance configu | Option Name | Description | | --------------| ------------ | -| `CONSTRAINTS` | A list of constraints that apply to all roles. For example, `CONSTRAINTS="[+disk=ssd]`. | +| `CONSTRAINTS` | A list of constraints that apply to all roles. For example, `CONSTRAINTS="[+disk=ssd]"`. | | `LEADER_CONSTRAINTS` | A list of constraints that only apply to leader. | | `FOLLOWER_CONSTRAINTS` | A list of constraints that only apply to followers. | | `LEARNER_CONSTRAINTS` | A list of constraints that only apply to learners. | @@ -247,7 +247,7 @@ In dictionary format, constraints also indicate a number of instances that apply | Tool Name | Minimum supported version | Description | | --- | --- | --- | -| Backup & Restore (BR) | 6.0 | Supports importing and exporting placement rules. Refer to [BR Compatibility](/br/backup-and-restore-tool.md#compatibility] for details. | +| Backup & Restore (BR) | 6.0 | Supports importing and exporting placement rules. Refer to [BR Compatibility](/br/backup-and-restore-tool.md#compatibility) for details. | | TiDB Lightning | Not compatible yet | | | TiCDC | 6.0 | Ignores placement rules, and does not replicate the rules to the downstream | | TiDB Binlog | 6.0 | Ignores placement rules, and does not replicate the rules to the downstream | From cce30cf791e635414bfa65de59f052f15180ac97 Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Fri, 1 Apr 2022 16:22:23 +0800 Subject: [PATCH 2/3] Update the link of privacy policy --- telemetry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/telemetry.md b/telemetry.md index 727412ab49a32..ebb09737529d5 100644 --- a/telemetry.md +++ b/telemetry.md @@ -262,4 +262,4 @@ To meet compliance requirements in different countries or regions, the usage inf - For IP addresses from the Chinese mainland, usage information is sent to and stored on cloud servers in the Chinese mainland. - For IP addresses from outside of the Chinese mainland, usage information is sent to and stored on cloud servers in the US. -See [PingCAP Privacy Policy](https://pingcap.com/privacy-policy) for details. +See [PingCAP Privacy Policy](https://en.pingcap.com/privacy-policy/) for details. From 91bd8abfb494f09f883b6f5cca6f777075bd072b Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Fri, 1 Apr 2022 16:25:41 +0800 Subject: [PATCH 3/3] Apply suggestions from code review --- placement-rules-in-sql.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/placement-rules-in-sql.md b/placement-rules-in-sql.md index 4fda889f20992..c1099b1b1ea92 100644 --- a/placement-rules-in-sql.md +++ b/placement-rules-in-sql.md @@ -127,7 +127,7 @@ In addition to the placement options above, you can also use the advance configu | Option Name | Description | | --------------| ------------ | -| `CONSTRAINTS` | A list of constraints that apply to all roles. For example, `CONSTRAINTS="[+disk=ssd]"`. | +| `CONSTRAINTS` | A list of constraints that apply to all roles. For example, `CONSTRAINTS="[+disk=ssd]`. | | `LEADER_CONSTRAINTS` | A list of constraints that only apply to leader. | | `FOLLOWER_CONSTRAINTS` | A list of constraints that only apply to followers. | | `LEARNER_CONSTRAINTS` | A list of constraints that only apply to learners. | @@ -247,7 +247,7 @@ In dictionary format, constraints also indicate a number of instances that apply | Tool Name | Minimum supported version | Description | | --- | --- | --- | -| Backup & Restore (BR) | 6.0 | Supports importing and exporting placement rules. Refer to [BR Compatibility](/br/backup-and-restore-tool.md#compatibility) for details. | +| Backup & Restore (BR) | 6.0 | Supports importing and exporting placement rules. Refer to [BR Compatibility](/br/backup-and-restore-tool.md#compatibility] for details. | | TiDB Lightning | Not compatible yet | | | TiCDC | 6.0 | Ignores placement rules, and does not replicate the rules to the downstream | | TiDB Binlog | 6.0 | Ignores placement rules, and does not replicate the rules to the downstream |