Skip to content

asan: Fix compile error#6246

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
JaySon-Huang:fix_ps_gc
Nov 4, 2022
Merged

asan: Fix compile error#6246
ti-chi-bot merged 1 commit into
pingcap:masterfrom
JaySon-Huang:fix_ps_gc

Conversation

@JaySon-Huang
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #6218

Problem Summary:
introduced by #6237

dbms/CMakeFiles/gtests_dbms.dir/src/Encryption/tests/gtest_encryption_test.cpp.o -MF dbms/CMakeFiles/gtests_dbms.dir/src/Encryption/tests/gtest_encryption_test.cpp.o.d -o dbms/CMakeFiles/gtests_dbms.dir/src/Encryption/tests/gtest_encryption_test.cpp.o -c /home/jenkins/agent/workspace/tiflash-sanitizer-daily/tiflash/dbms/src/Encryption/tests/gtest_encryption_test.cpp
[2022-11-03T18:51:02.553Z] /home/jenkins/agent/workspace/tiflash-sanitizer-daily/tiflash/dbms/src/Encryption/tests/gtest_encryption_test.cpp:236:13: error: expected expression
[2022-11-03T18:51:02.553Z]             )));
[2022-11-03T18:51:02.553Z]             ^
[2022-11-03T18:51:02.553Z] 1 error generated.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@JaySon-Huang JaySon-Huang requested a review from lidezhu November 4, 2022 01:52
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2022
@JaySon-Huang
Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: da4c2fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@ti-chi-bot ti-chi-bot merged commit f8c0c28 into pingcap:master Nov 4, 2022
@JaySon-Huang JaySon-Huang deleted the fix_ps_gc branch November 4, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants