PageStorage: remove useless interface

[JaySon-Huang]

What problem does this PR solve?

Issue Number: ref #4562

Problem Summary:

What is changed and how it works?

PageIds PageStorage::read(NamespaceId ns_id, const PageIds & page_ids, const PageHandler & handler, const ReadLimiterPtr & read_limiter = nullptr, SnapshotPtr snapshot = {}, bool throw_on_not_exist = true)
is useless. It is only used for testing and can be totally replaced by another function.

Also add more test case following #6237. Concurrent about creating ref page and full gc.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Lloyd-Pottiger
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

/cc @lidezhu @Lloyd-Pottiger @hehechen

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: e1cc239

[ti-chi-bot]

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Lloyd-Pottiger]

/run-unit-test

[Lloyd-Pottiger]

one ut failed

[2022-11-08T01:18:20.886Z] FAILED TESTS (1/1719):
[2022-11-08T01:18:20.886Z]     1187 ms: /tiflash/gtests_dbms PageStorageTest.readNotThrowOnNotFound

[2022-11-08T01:15:05.387Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Page/V3/tests/gtest_page_storage.cpp:426: Failure
[2022-11-08T01:15:05.387Z] Expected: (page_maps.count(2)) > (0), actual: 0 vs 0
[2022-11-08T01:15:05.387Z] [2022/11/08 09:15:04.570 +08:00] [ERROR] [Exception.cpp:89] ["std::exception. Code: 1001, type: testing::AssertionException, e.what() = /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Page/V3/tests/gtest_page_storage.cpp:426: Failure\nExpected: (page_maps.count(2)) > (0), actual: 0 vs 0"] [source="virtual void DB::PS::V3::tests::PageStorageTest_readNotThrowOnNotFound_Test::TestBody()"] [thread_id=1]
[2022-11-08T01:15:05.387Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Page/V3/tests/gtest_page_storage.cpp:432: Failure
[2022-11-08T01:15:05.387Z] Failed

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: f8c59ec