Fix null vs undefined environment scoping and remove unused exports

- Replace `??` with explicit undefined check in runSnapshotRecovery so
  that an explicit null environmentId is preserved rather than falling
  through to the active environment.
- Remove unused exported functions (scopeThreadSessionRef,
  resolveEnvironmentClient, tagEnvironmentValue, attachEnvironmentDescriptor)
  and their supporting types from client-runtime.

Author: cursoragent

apps/web/src/routes/__root.tsx

@@ -531,7 +531,10 @@ function EventRouter() {
       try {
         const snapshot = await api.orchestration.getSnapshot();
         if (!disposed) {
-          syncServerReadModel(snapshot, environmentId ?? resolveCurrentEnvironmentId());
+          syncServerReadModel(
+            snapshot,
+            environmentId !== undefined ? environmentId : resolveCurrentEnvironmentId(),
+          );
           reconcileSnapshotDerivedState();
           if (recovery.completeSnapshotRecovery(snapshot.snapshotSequence)) {
             void runReplayRecovery("sequence-gap");

packages/client-runtime/src/knownEnvironment.ts

@@ -1,4 +1,4 @@
-import type { EnvironmentId, ExecutionEnvironmentDescriptor } from "@t3tools/contracts";
+import type { EnvironmentId } from "@t3tools/contracts";
 
 export interface KnownEnvironmentConnectionTarget {
   readonly type: "ws";
@@ -37,14 +37,3 @@ export function getKnownEnvironmentBaseUrl(
 ): string | null {
   return environment?.target.wsUrl ?? null;
 }
-
-export function attachEnvironmentDescriptor(
-  environment: KnownEnvironment,
-  descriptor: ExecutionEnvironmentDescriptor,
-): KnownEnvironment {
-  return {
-    ...environment,
-    environmentId: descriptor.environmentId,
-    label: descriptor.label,
-  };
-}

packages/client-runtime/src/scoped.ts

@@ -2,20 +2,10 @@ import type {
   EnvironmentId,
   ProjectId,
   ScopedProjectRef,
-  ScopedThreadSessionRef,
   ScopedThreadRef,
   ThreadId,
 } from "@t3tools/contracts";
 
-interface EnvironmentScopedRef<TId extends string> {
-  readonly environmentId: EnvironmentId;
-  readonly id: TId;
-}
-
-export interface EnvironmentClientRegistry<TClient> {
-  readonly getClient: (environmentId: EnvironmentId) => TClient | null | undefined;
-}
-
 export function scopeProjectRef(
   environmentId: EnvironmentId,
   projectId: ProjectId,
@@ -27,34 +17,7 @@ export function scopeThreadRef(environmentId: EnvironmentId, threadId: ThreadId)
   return { environmentId, threadId };
 }
 
-export function scopeThreadSessionRef(
-  environmentId: EnvironmentId,
-  threadId: ThreadId,
-): ScopedThreadSessionRef {
-  return { environmentId, threadId };
-}
-
-export function scopedRefKey(
-  ref: EnvironmentScopedRef<string> | ScopedProjectRef | ScopedThreadRef | ScopedThreadSessionRef,
-): string {
-  const localId = "id" in ref ? ref.id : "projectId" in ref ? ref.projectId : ref.threadId;
+export function scopedRefKey(ref: ScopedProjectRef | ScopedThreadRef): string {
+  const localId = "projectId" in ref ? ref.projectId : ref.threadId;
   return `${ref.environmentId}:${localId}`;
 }
-
-export function resolveEnvironmentClient<TClient>(
-  registry: EnvironmentClientRegistry<TClient>,
-  ref: EnvironmentScopedRef<string>,
-): TClient {
-  const client = registry.getClient(ref.environmentId);
-  if (!client) {
-    throw new Error(`No client registered for environment ${ref.environmentId}.`);
-  }
-  return client;
-}
-
-export function tagEnvironmentValue<T>(
-  environmentId: EnvironmentId,
-  value: T,
-): { readonly environmentId: EnvironmentId; readonly value: T } {
-  return { environmentId, value };
-}