Commit 5228114
committed
fix: surface git status stream errors to UI via onError callback
The subscribeToGitStatus function only updated the atom's data field on
stream events but never populated error or cause. This meant the error
display UI in GitActionsControl was dead code — gitStatusError was
always null.
Added an onError callback to SubscribeOptions (WsTransport) and
StreamSubscriptionOptions (wsRpcClient), invoked when the stream
disconnects with an error. subscribeToGitStatus now uses this callback
to set the error and cause fields on the git status atom, allowing the
existing UI error rendering path to work.1 parent e234ed0 commit 5228114
File tree
3 files changed
+18
-0
lines changed- apps/web/src
- lib
3 files changed
+18
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
196 | 207 | | |
197 | 208 | | |
198 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
147 | 148 | | |
148 | 149 | | |
149 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
150 | 156 | | |
151 | 157 | | |
152 | 158 | | |
| |||
0 commit comments