fix: defer launchctl subprocess, remove dead resolveLoginShell, capture error in outer catch

- Defer readPathFromLaunchctl() on macOS so it only spawns when the login
  shell did not provide a PATH (avoids unnecessary synchronous subprocess)
- Remove resolveLoginShell which had no production callers after refactor
- Capture error object in outer catch of syncShellEnvironment.ts to match
  the os-jank.ts pattern and preserve error details in log output

Author: cursoragent

apps/desktop/src/syncShellEnvironment.ts

@@ -50,7 +50,9 @@ export function syncShellEnvironment(
     }
 
     const launchctlPath =
-      platform === "darwin" ? (options.readLaunchctlPath ?? readPathFromLaunchctl)() : undefined;
+      platform === "darwin" && !shellEnvironment.PATH
+        ? (options.readLaunchctlPath ?? readPathFromLaunchctl)()
+        : undefined;
     const mergedPath = mergePathEntries(shellEnvironment.PATH ?? launchctlPath, env.PATH, platform);
     if (mergedPath) {
       env.PATH = mergedPath;
@@ -71,7 +73,7 @@ export function syncShellEnvironment(
         env[name] = shellEnvironment[name];
       }
     }
-  } catch {
-    logWarning("Failed to synchronize the desktop shell environment.");
+  } catch (error) {
+    logWarning("Failed to synchronize the desktop shell environment.", error);
   }
 }

apps/server/src/os-jank.ts

@@ -43,7 +43,9 @@ export function fixPath(
     }
 
     const launchctlPath =
-      platform === "darwin" ? (options.readLaunchctlPath ?? readPathFromLaunchctl)() : undefined;
+      platform === "darwin" && !shellPath
+        ? (options.readLaunchctlPath ?? readPathFromLaunchctl)()
+        : undefined;
     const mergedPath = mergePathEntries(shellPath ?? launchctlPath, env.PATH, platform);
     if (mergedPath) {
       env.PATH = mergedPath;

packages/shared/src/shell.test.ts

@@ -7,7 +7,6 @@ import {
   readEnvironmentFromLoginShell,
   readPathFromLaunchctl,
   readPathFromLoginShell,
-  resolveLoginShell,
 } from "./shell";
 
 describe("extractPathFromShellOutput", () => {
@@ -176,14 +175,6 @@ describe("listLoginShellCandidates", () => {
   });
 });
 
-describe("resolveLoginShell", () => {
-  it("returns the first available login shell candidate", () => {
-    expect(resolveLoginShell("darwin", undefined, "/opt/homebrew/bin/fish")).toBe(
-      "/opt/homebrew/bin/fish",
-    );
-  });
-});
-
 describe("mergePathEntries", () => {
   it("prefers login-shell PATH entries and keeps inherited extras", () => {
     expect(

packages/shared/src/shell.ts

@@ -45,14 +45,6 @@ export function listLoginShellCandidates(
   return candidates;
 }
 
-export function resolveLoginShell(
-  platform: NodeJS.Platform,
-  shell: string | undefined,
-  userShell = readUserLoginShell(),
-): string | undefined {
-  return listLoginShellCandidates(platform, shell, userShell)[0];
-}
-
 export function extractPathFromShellOutput(output: string): string | null {
   const startIndex = output.indexOf(PATH_CAPTURE_START);
   if (startIndex === -1) return null;