Skip to content

Commit 552d1cf

Browse files
committed
Fix fallback log message never emitted due to mutated state
Capture the requested serverExposureMode before calling applyDesktopServerExposureMode, which mutates desktopSettings. The fallback diagnostic check now compares against the original requested mode instead of the already-overwritten value.
1 parent 222d86b commit 552d1cf

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

apps/desktop/src/main.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1667,18 +1667,16 @@ async function bootstrap(): Promise<void> {
16671667
`bootstrap restoring persisted server exposure mode mode=${desktopSettings.serverExposureMode}`,
16681668
);
16691669
}
1670-
const serverExposureState = await applyDesktopServerExposureMode(
1671-
desktopSettings.serverExposureMode,
1672-
{
1673-
persist: desktopSettings.serverExposureMode !== DEFAULT_DESKTOP_SETTINGS.serverExposureMode,
1674-
},
1675-
);
1670+
const requestedExposureMode = desktopSettings.serverExposureMode;
1671+
const serverExposureState = await applyDesktopServerExposureMode(requestedExposureMode, {
1672+
persist: requestedExposureMode !== DEFAULT_DESKTOP_SETTINGS.serverExposureMode,
1673+
});
16761674
writeDesktopLogHeader(`bootstrap resolved backend endpoint baseUrl=${backendHttpUrl}`);
16771675
if (serverExposureState.endpointUrl) {
16781676
writeDesktopLogHeader(
16791677
`bootstrap enabled network access endpointUrl=${serverExposureState.endpointUrl}`,
16801678
);
1681-
} else if (desktopSettings.serverExposureMode === "network-accessible") {
1679+
} else if (requestedExposureMode === "network-accessible") {
16821680
writeDesktopLogHeader(
16831681
"bootstrap fell back to local-only because no advertised network host was available",
16841682
);

0 commit comments

Comments
 (0)