Scope setup script catch to only handle runForThread failures

Add Effect.ignoreCause to the activity dispatch inside Effect.tap so
that errors from appendSetupScriptActivity don't propagate to the outer
Effect.catch handler. Previously, if the setup script started
successfully but the activity dispatch failed, the catch handler would
incorrectly emit a setup-script.failed activity even though the terminal
was already open and the script command had already been written.

Author: cursoragent

apps/server/src/wsServer.ts

@@ -674,11 +674,10 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
                       payload,
                       tone: "info",
                     }),
-                  ]).pipe(Effect.asVoid);
+                  ]).pipe(Effect.asVoid, Effect.ignoreCause({ log: true }));
                 }),
                 Effect.catch((error) => {
-                  const detail =
-                    error instanceof Error ? error.message : "Unknown setup failure.";
+                  const detail = error instanceof Error ? error.message : "Unknown setup failure.";
                   return appendSetupScriptActivity({
                     threadId: command.threadId,
                     kind: "setup-script.failed",
@@ -692,14 +691,11 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
                   }).pipe(
                     Effect.ignoreCause({ log: false }),
                     Effect.zipRight(
-                      Effect.logWarning(
-                        "bootstrap turn start failed to launch setup script",
-                        {
-                          threadId: command.threadId,
-                          worktreePath,
-                          detail,
-                        },
-                      ),
+                      Effect.logWarning("bootstrap turn start failed to launch setup script", {
+                        threadId: command.threadId,
+                        worktreePath,
+                        detail,
+                      }),
                     ),
                   );
                 }),