From fd3f652f68e3dab61009c52d8c0143fe0e83ab87 Mon Sep 17 00:00:00 2001 From: BinBandit Date: Mon, 9 Mar 2026 13:40:09 +1100 Subject: [PATCH] refactor(contracts): remove unused OrchestrationPersistedEvent schema OrchestrationPersistedEvent and its PersistedEventBaseFields helper were added in 25d20ab7 but never imported or referenced anywhere in the codebase. The actual persistence layer (OrchestrationEventStore) defines its own local schema with different field names. Remove this dead code to reduce maintenance surface in orchestration.ts. --- packages/contracts/src/orchestration.ts | 118 ------------------------ 1 file changed, 118 deletions(-) diff --git a/packages/contracts/src/orchestration.ts b/packages/contracts/src/orchestration.ts index e90ddd4b59..af496ad2a9 100644 --- a/packages/contracts/src/orchestration.ts +++ b/packages/contracts/src/orchestration.ts @@ -769,20 +769,6 @@ const EventBaseFields = { metadata: OrchestrationEventMetadata, } as const; -const PersistedEventBaseFields = { - sequence: NonNegativeInt, - eventId: EventId, - aggregateKind: OrchestrationAggregateKind, - streamId: Schema.Union([ProjectId, ThreadId]), - streamVersion: NonNegativeInt, - occurredAt: IsoDateTime, - commandId: Schema.NullOr(CommandId), - causationEventId: Schema.NullOr(EventId), - correlationId: Schema.NullOr(CommandId), - actorKind: OrchestrationActorKind, - metadata: OrchestrationEventMetadata, -} as const; - export const OrchestrationEvent = Schema.Union([ Schema.Struct({ ...EventBaseFields, @@ -887,110 +873,6 @@ export const OrchestrationEvent = Schema.Union([ ]); export type OrchestrationEvent = typeof OrchestrationEvent.Type; -export const OrchestrationPersistedEvent = Schema.Union([ - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("project.created"), - payload: ProjectCreatedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("project.meta-updated"), - payload: ProjectMetaUpdatedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("project.deleted"), - payload: ProjectDeletedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.created"), - payload: ThreadCreatedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.deleted"), - payload: ThreadDeletedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.meta-updated"), - payload: ThreadMetaUpdatedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.runtime-mode-set"), - payload: ThreadRuntimeModeSetPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.interaction-mode-set"), - payload: ThreadInteractionModeSetPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.message-sent"), - payload: ThreadMessageSentPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.turn-start-requested"), - payload: ThreadTurnStartRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.turn-interrupt-requested"), - payload: ThreadTurnInterruptRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.approval-response-requested"), - payload: ThreadApprovalResponseRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.user-input-response-requested"), - payload: ThreadUserInputResponseRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.checkpoint-revert-requested"), - payload: ThreadCheckpointRevertRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.reverted"), - payload: ThreadRevertedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.session-stop-requested"), - payload: ThreadSessionStopRequestedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.session-set"), - payload: ThreadSessionSetPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.proposed-plan-upserted"), - payload: ThreadProposedPlanUpsertedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.turn-diff-completed"), - payload: ThreadTurnDiffCompletedPayload, - }), - Schema.Struct({ - ...PersistedEventBaseFields, - eventType: Schema.Literal("thread.activity-appended"), - payload: ThreadActivityAppendedPayload, - }), -]); -export type OrchestrationPersistedEvent = typeof OrchestrationPersistedEvent.Type; - export const OrchestrationCommandReceiptStatus = Schema.Literals(["accepted", "rejected"]); export type OrchestrationCommandReceiptStatus = typeof OrchestrationCommandReceiptStatus.Type;