Skip to content

update pingcli-- to pingcli__ because it makes it easier to copy paste #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikostien-pingidentity merged 3 commits into from
Mar 28, 2025
Merged

update pingcli-- to pingcli__ because it makes it easier to copy paste #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6d848
update pingcli-- to pingcli__ because it makes it easier to copy and …
samir-gandhi Mar 14, 2025
7aa5844
Merge branch 'main' into export-prefix
samir-gandhi Mar 28, 2025
3d35661
typo for lint
samir-gandhi Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/connector/common/common_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func WriteFiles(exportableResources []connector.ExportableResource, format, outp
}

for _, importBlock := range *importBlocks {
// Sanitize import block "to". Add pingcli-- prefix, hexadecimal encode special chars and spaces
// Sanitize import block "to". Add pingcli__ prefix, hexadecimal encode special chars and spaces
importBlock.Sanitize()

switch format {
Expand Down
4 changes: 2 additions & 2 deletions internal/connector/exportable_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ func (b *ImportBlock) Sanitize() {
b.ResourceName = regexp.MustCompile(`[^0-9A-Za-z_\-]`).ReplaceAllStringFunc(b.ResourceName, func(s string) string {
return fmt.Sprintf("-%04X-", s)
})
// Prefix resource names with pingcli--
b.ResourceName = "pingcli--" + b.ResourceName
// Prefix resource names with pingcli__
b.ResourceName = "pingcli__" + b.ResourceName
}

func (b *ImportBlock) Equals(a ImportBlock) bool {
Expand Down
2 changes: 1 addition & 1 deletion internal/connector/exportable_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

// Test sanitization of resource name
func TestSanitize(t *testing.T) {
sanitizedResourceName := "pingcli--Customer-0020-HTML-0020-Form-0020--0028-PF-0029-"
sanitizedResourceName := "pingcli__Customer-0020-HTML-0020-Form-0020--0028-PF-0029-"

importBlock := connector.ImportBlock{
ResourceName: "Customer HTML Form (PF)",
Expand Down