PIX-62 introduced typesafety in socket functions

Author: matteosusca

client/src/services/socket.service.ts

@@ -39,15 +39,15 @@ class SocketService {
     this.socket?.emit('JOIN_LOBBY', lobbyName);
   }
 
-  onLobbyUsers(cb: (users: any[]) => void) {
+  onLobbyUsers<T>(cb: (users: T[]) => void) {
     this.socket?.on('LOBBY_USERS', cb);
   }
 
-  onUserJoined(cb: (user: any) => void) {
+  onUserJoined<T>(cb: (user: T) => void) {
     this.socket?.on('USER_JOINED', cb);
   }
 
-  onUserLeft(cb: (user: any) => void) {
+  onUserLeft<T>(cb: (user: T) => void) {
     this.socket?.on('USER_LEFT', cb);
   }
 

client/src/stores/lobby.store.ts

@@ -26,20 +26,22 @@ export const useLobbyStore = defineStore('lobby', () => {
     });
 
     // Listen for initial user list
-    socketService.onLobbyUsers((userList: User[]) => {
+    socketService.onLobbyUsers<User>((userList) => {
       users.value = userList;
     });
 
     // Listen for new user joining
-    socketService.onUserJoined((user: User) => {
+    // Listen for new user joining
+    socketService.onUserJoined<User>((user) => {
       // Avoid duplicates
       if (!users.value.find(u => u.id === user.id)) {
         users.value.push(user);
       }
     });
 
     // Listen for user leaving
-    socketService.onUserLeft((user: User) => {
+    // Listen for user leaving
+    socketService.onUserLeft<User>((user) => {
       users.value = users.value.filter(u => u.id !== user.id);
     });
   };