Skip to content

Commit 79ccd83

Browse files
committed
Various fixes
- Fix INI default loading - Fix $_SERVER paths - Do not supress errors when loading .node bindings file - Fix response build timing to not miss buffered headers - Improved safety of current request context retrieval
1 parent 3ea6bd3 commit 79ccd83

File tree

5 files changed

+147
-86
lines changed

5 files changed

+147
-86
lines changed

.github/workflows/CI.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ jobs:
138138
with:
139139
repository: php/php-src
140140
path: php-src
141+
ref: PHP-8.4
141142
- name: Install dependencies
142143
run: pnpm install
143144
- name: Give GitHub Actions access to ext-php-rs

INTERNALS.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,13 @@ make -j$([[ "$(uname)" == "Darwin" ]] && sysctl -n hw.physicalcpu || nproc)
1313
sudo make install
1414
```
1515

16+
```sh
17+
./buildconf
18+
./configure --enable-shared --enable-embed=shared --enable-zts --with-config-file-path=/usr/local/etc/php --with-config-file-scan-dir=/usr/local/etc/php/conf.d --enable-option-checking=fatal --with-mhash --with-pic --enable-mbstring --enable-mysqlnd --with-password-argon2 --with-sodium=shared --with-pdo-sqlite=/usr --with-sqlite3=/usr --with-curl --with-iconv --with-openssl --with-readline --with-zlib --disable-phpdbg --with-pear --disable-cgi
19+
make -j$([[ "$(uname)" == "Darwin" ]] && sysctl -n hw.physicalcpu || nproc)
20+
sudo make install
21+
```
22+
1623
We'll probably want to build with additional extensions later, but this is a
1724
good starting point. Extensions should be able to load dynamically anyway,
1825
so easy enough to add them separately.

0 commit comments

Comments
 (0)